Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved queries JS #89

Closed
lucasvel opened this issue Feb 27, 2013 · 1 comment
Closed

Saved queries JS #89

lucasvel opened this issue Feb 27, 2013 · 1 comment
Assignees
@leikind

Comments

@lucasvel
Copy link

Hi, I got 2 js errors when using saved queries

in vendor/assets/javascripts/wice_grid_saved_queries_init.js.coffee:91
Uncaught ReferenceError: errorExplanation is not defined and error messages are not been displayed

$(notificationMessagesDomId).text(errorExplanation)

should be

$(notificationMessagesDomId).text(errorMessages)

I'm not using jQuery UI but Twitter Bootstrap so in vendor/assets/javascripts/wice_grid_saved_queries_init.js.coffee:97
Uncaught TypeError: Object [object Object] has no method 'effect'

$(queryListId).effect('highlight')

could be

$(queryListId).effect('highlight') if jQuery.ui

Thank you!
@ghost ghost assigned leikind Feb 27, 2013
@leikind
Copy link
Owner

leikind commented May 15, 2013

Fixed ( 69e7052 ). Thanks. Better late than never :)

@leikind leikind closed this as completed May 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leikind leikind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leikind @lucasvel