Fix import prefix trailing slash #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
added a commit
to cosmos/vanity
that referenced
this pull request
Aug 1, 2024
tac0turtle
pushed a commit
to cosmos/vanity
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change the import prefix that gets rendered when the import prefix is a domain only with no path, to have no trailing slash.
Why
The templates that generate the pages always insert a slash at the end of the domain for the import prefix assuming a path follows, and when a path doesn't follow that results in a trailing slash.
Go import paths don't usually has trailing slashes on the end of the import path.
I suspect this might be the cause of why import prefixes for repos that don't have a path are not integrating well with pkg.go.dev.
Close #19