Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository URL not available #19

Closed
julienrbrt opened this issue Jul 31, 2024 · 5 comments · Fixed by #20
Closed

Repository URL not available #19

julienrbrt opened this issue Jul 31, 2024 · 5 comments · Fixed by #20
Assignees

Comments

@julienrbrt
Copy link

julienrbrt commented Jul 31, 2024

We are using vangen for https://github.com/cosmos/vanity, works great thanks!
However, the repository URL doesn't show up in pkg.go.dev:

image

@leighmcculloch
Copy link
Owner

Hi @julienrbrt, thanks for reporting.

It looks like the vanity page (e.g. https://cosmossdk.io/api/) has meta:

<meta name="go-import" content="cosmossdk.io/ git https://github.com/cosmos/cosmos-sdk">
<meta name="go-source" content="cosmossdk.io/ https://github.com/cosmos/cosmos-sdk https://github.com/cosmos/cosmos-sdk/tree/main{/dir} https://github.com/cosmos/cosmos-sdk/blob/main{/dir}/{file}#L{line}">

The thing that seems odd is that for both the go-import and go-source the leading import path is supposed to be cosmossdk.io/api not cosmossdk.io/.

@leighmcculloch
Copy link
Owner

leighmcculloch commented Aug 1, 2024

Ah, I see it is one large repo not individual repos, and so the cosmossdk.io is the root of the repo. I wonder if the slash on the end is the problem? i.e. the cosmossdk.io/

Import prefixes do not usually have a trailing slash so it might be considering it as invalid.

Ref: https://pkg.go.dev/cmd/go#hdr-Remote_import_paths

@leighmcculloch
Copy link
Owner

leighmcculloch commented Aug 1, 2024

@julienrbrt I've pushed a fix in #20. Are you able to try regenerating your vanity page using #20, and then try getting pkg.go.dev to refresh your package to confirm if that resolves the issue?

@julienrbrt
Copy link
Author

Hey, that did it: https://pkg.go.dev/cosmossdk.io/log
Thanks!

@leighmcculloch
Copy link
Owner

Excellent! I've merged the fix and released it in v1.4.1. Thanks again for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants