Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sampling vertices from subtractions #56

Closed
gipert opened this issue Jul 6, 2023 · 8 comments · Fixed by #220
Closed

Implement sampling vertices from subtractions #56

gipert opened this issue Jul 6, 2023 · 8 comments · Fixed by #220
Assignees
Labels
generators Event generators

Comments

@gipert
Copy link
Member

gipert commented Jul 6, 2023

Useful to simulate e.g. K42 decays outside mini-shroud but inside cylinder.

@gipert gipert changed the title Implement sampling verices from subtractions Implement sampling vertices from subtractions Jul 12, 2023
@gipert gipert added the generators Event generators label Nov 10, 2024
@gipert
Copy link
Member Author

gipert commented Nov 10, 2024

I'm not sure what I meant here, but this seems to me already supported.

@gipert gipert closed this as completed Nov 10, 2024
@ManuelHu
Copy link
Collaborator

I suppose you meant "from a substraction of two user-defined solids" (i.e. where none of them is from the original geometry). This is not yet possible

@gipert
Copy link
Member Author

gipert commented Nov 11, 2024

Ah yes you are right...

@tdixon97
Copy link
Collaborator

do we really need this? whats the application? E..g LAr inside MS can be simulated already

@gipert
Copy link
Member Author

gipert commented Dec 24, 2024

LAr outside MS?

@tdixon97
Copy link
Collaborator

tdixon97 commented Dec 24, 2024

Yes I get it now what you want is to select points where A & !B compared to what you have now which is A& B. Although thats slightly different to what Manuel suggested above.
Do we really want to add more features to the RMG generators though, or move to python entirely? For me its seems much easier, and better to do it sooner. Although this is probably really easy to implement (but harder to test in c++)

@gipert
Copy link
Member Author

gipert commented Dec 24, 2024

In C++ we have ::IsInside(), that's quite crucial...

@tdixon97
Copy link
Collaborator

Ok now I am remembering this discussion. I will work on this implementation and meanwhile think of some high level tests we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generators Event generators
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants