Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix analysis_data.channel_mean() #72

Open
Tracked by #62
sofia-calgaro opened this issue Mar 8, 2023 · 1 comment
Open
Tracked by #62

fix analysis_data.channel_mean() #72

sofia-calgaro opened this issue Mar 8, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@sofia-calgaro
Copy link
Collaborator

No description provided.

@sofia-calgaro sofia-calgaro mentioned this issue Mar 8, 2023
45 tasks
@sofia-calgaro sofia-calgaro changed the title fix analysis_data.channel_mean() when we deal with parameters of which we don want to get the mean (eg waveforms, energy in PE, ...). These parameters can belong to whatever subsystem (geds, pulser, spms), so we have to look at their type for instance...not so trivial, basic implementation is there at the moment: for the moment, we skip only spms, indipendently from the inspected parameter. fix analysis_data.channel_mean() Mar 8, 2023
@sofia-calgaro
Copy link
Collaborator Author

We don't want to calculate the mean when we deal with given parameters that are like Vectors of Vectors (eg waveforms, energy in PE, ...). These parameters can belong to whatever subsystem (geds, pulser, spms), so we have to look at their type. This is not very trivial because self.paramters is itself a list of parameters, so in principle one should need to loop over every single parameter.

A basic workaround is there at the moment, that skips only spms, independently from the inspected parameter.
This means that if we are going to load waveforms from raw tiers for geds, the code will potentially crash. However, loading waveform is not our purpose, so we might be already happy with this version

@sofia-calgaro sofia-calgaro added the help wanted Extra attention is needed label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant