Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCStatusDecoder assumes a single FC card, errors if multiple cards #8

Open
slwatkins opened this issue Aug 16, 2023 · 4 comments
Open
Labels
bug Something isn't working

Comments

@slwatkins
Copy link
Member

I've been working with the decoders to validate the FC and ORCA files being created to ensure no data is lost, and the FCStatusDecoder errors at these lines when there are multiple cards being logged.

# FC card-wise environment status (temp., volt., hum., ...)
tbl["environment"].nda[ii][:] = fcio.environment
# FC card-wise list DAQ errors during data taking
tbl["totalerrors"].nda[ii] = fcio.totalerrors
tbl["linkerrors"].nda[ii] = fcio.linkerrors
tbl["ctierrors"].nda[ii] = fcio.ctierrors
tbl["enverrors"].nda[ii] = fcio.enverrors
tbl["othererrors"].nda[ii][:] = fcio.othererrors

This is reproducible with, e.g., the tst file l200-p04-r006-tst-20230510T101033Z_FCIO_1.fcio, using the below code:

from daq2lh5.fc import fc_streamer

fc_file1 = 'l200-p04-r006-tst-20230510T101033Z_FCIO_1.fcio'

fcstr1 = fc_streamer.FCStreamer()
fcstr1.open_stream(fc_file1)
fcstr1.read_chunk()

which errors at the quoted lines, due to each value being either a list of lists or a list.

@slwatkins slwatkins changed the title FCStatusDecoder assumes a single FC card, errors if multiple FCStatusDecoder assumes a single FC card, errors if multiple cards Aug 16, 2023
@gipert gipert added the bug Something isn't working label Sep 12, 2023
@gipert
Copy link
Member

gipert commented Sep 12, 2023

Would it be possible to produce a short test file to upload to legend-testdata? Maybe @ssailer has access to the L200 DAQ machine and knows how to do that?

@jasondet what do we need to do in order to fix this?

@ssailer
Copy link
Collaborator

ssailer commented Sep 12, 2023

I had a quick check: Only the first card is exposed, see legend-exp/pyfcutils#39
This is usually the MasterCard.

@jasondet
Copy link
Collaborator

I have turned status decoding off for now while Simon updates the pyfcutils interface.

@jasondet jasondet reopened this Oct 24, 2023
@jasondet
Copy link
Collaborator

I closed the wrong issue 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants