You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should take care to get all PSD parameters from normalized waveforms. Here the normalization factor (E) should be the same across the processing chain (A/E, QDrift/E, ...) and equal to a filtered maximum of the waveform in ADC.
Therefore in:
Agreed, that should be an easy fix. I will include a new metadata parameter which controls which energy estimator will be used for that.
I don't think it makes a huge difference right now but you are right.
For the current processing, I would go with e_cusp then since this is at the moment our default energy estimator.
We should take care to get all PSD parameters from normalized waveforms. Here the normalization factor (
E
) should be the same across the processing chain (A/E
,QDrift/E
, ...) and equal to a filtered maximum of the waveform in ADC.Therefore in:
LegendDSP.jl/src/dsp_icpc.jl
Lines 138 to 142 in acb4c56
wvf_max
should be replaced bye_cusp
ore_trap
The text was updated successfully, but these errors were encountered: