Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modals don't show on new ui (again) #1

Open
1nikolas opened this issue Jun 26, 2022 · 9 comments
Open

Modals don't show on new ui (again) #1

1nikolas opened this issue Jun 26, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@1nikolas
Copy link
Collaborator

It has something to do with the hide-preferences-window class on body (just like the last time). If you remove it, it works

image

@1nikolas
Copy link
Collaborator Author

document.documentElement.classList.remove("hide-preferences-window");
this should just fix the problem but I don't know if it breaks anything. I have no idea what hide-preferences-window is used for..

@lefterisgar
Copy link
Owner

Hi and thanks for the issue and the PR! I can't replicate this issue however. I see you are on the latest version but maybe something in your Caprine install is messed up. Can you try removing this directory: %APPDATA%\Caprine? I'm saying that because images still show for me and can't find such an issue upstream.

@1nikolas
Copy link
Collaborator Author

I've got 2.55.7-1. I tried removing all the appdata and it still happens.. Maybe it has to do with the new messenger ui and you don't have it yet? They added a sidebar thing
image

@lefterisgar
Copy link
Owner

Oh, I see! Yeah, it's probably that. Give me a few hours and I'm going to merge it and create a new release so we can (hopefully) be prepared for when this change rolls out to everyone.

@1nikolas 1nikolas changed the title Images don't show (again) Modals don't show on new ui (again) Jun 30, 2022
@1nikolas
Copy link
Collaborator Author

1nikolas commented Jul 4, 2022

why did you close this? It is unrelated to the messenger app banner
this is what pr #2 hides
image

@lefterisgar
Copy link
Owner

@1nikolas I'm really sorry and I'm going to revert what I've done. I don't have the new Messenger UI as you, so I can't tell what's being fixed... Is there any way to get the new UI?

@lefterisgar lefterisgar reopened this Jul 4, 2022
@1nikolas
Copy link
Collaborator Author

1nikolas commented Jul 4, 2022

@1nikolas I'm really sorry and I'm going to revert what I've done. I don't have the new Messenger UI as you, so I can't tell what's being fixed... Is there any way to get the new UI?

You can maybe try opening a new account. Or it could just be random rollout at first

@lefterisgar
Copy link
Owner

Okay, thanks! By the way do you also know if this banner only shows up on Windows?

@1nikolas
Copy link
Collaborator Author

1nikolas commented Jul 4, 2022

It should only show on Windows and Mac if you use a normal browser but I don't know what User Agent electron is using

@lefterisgar lefterisgar added the bug Something isn't working label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants