Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rating is editable when not having clicked on the edit button in the movie page #280

Closed
JVT038 opened this issue Feb 14, 2023 · 1 comment · Fixed by #283
Closed

Rating is editable when not having clicked on the edit button in the movie page #280

JVT038 opened this issue Feb 14, 2023 · 1 comment · Fixed by #283
Labels
bug Something isn't working priority: middle A little bit important

Comments

@JVT038
Copy link
Collaborator

JVT038 commented Feb 14, 2023

When visiting a movie, I can change the rating without having changed on the edit button.
I believe you should only be able to edit the rating when clicking on the rating button right?
@leepeuker leepeuker added the bug Something isn't working label Feb 15, 2023
@leepeuker
Copy link
Owner

Oh good catch, that is definitively a bug. At least it does not persist anything

@leepeuker leepeuker added priority: high Very important priority: middle A little bit important and removed priority: high Very important labels Feb 15, 2023
@leepeuker leepeuker linked a pull request Feb 15, 2023 that will close this issue
Fix UX issues with rating stars on movie detail page #283
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority: middle A little bit important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UX issues with rating stars on movie detail page leepeuker/movary
2 participants
@leepeuker @JVT038