Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new candlestick chart demo #606

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

euprogramador
Copy link

@euprogramador euprogramador commented Oct 31, 2021

implemented demo use horizontalPanZoomScrollerPlugin() function.

Features demonstrated:

  • + / - keys to manage zoom
  • use mouse whell to horizontal
  • click and move to pan chart
  • y rescale

@leeoniya
Copy link
Owner

leeoniya commented Nov 3, 2021

thanks @euprogramador , i'll try to review this soon.

there's a good chance i'll backport some of the improvements from grafana/grafana#40909 to the current candlestick demo. generally i'd prefer to have fewer variants of the same code that can easily become out of sync, so it would be good to roll more stuff into the existing demo, but probably not before i update the original. WDYT?


/* left axis scale */

let leftAxisScale = u.root.querySelectorAll(".u-axis")[1];
Copy link
Owner

@leeoniya leeoniya Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to see use of cutting-edge features :)

this was exactly the use-case i had in mind for these rects, too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm implementing a trading system, and the graphic visualization in metatrader doesn't support the graphic types I want to create. I will actually use context2d to create cluster footprint charts. vertical scale will be required to implement these features.

as I saw that others wanted this, I decided to implement it in the example to help those who also want these features, I thought your project was really cool and very fast.

@leeoniya
Copy link
Owner

leeoniya commented Nov 6, 2021

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants