Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag data source empty if tags are in a culture #423

Open
1 task done
skttl opened this issue Nov 20, 2024 · 1 comment
Open
1 task done

Tag data source empty if tags are in a culture #423

skttl opened this issue Nov 20, 2024 · 1 comment
Assignees
Labels
affected/v5 help wanted Extra attention is needed type/bug-report Something isn't working

Comments

@skttl
Copy link
Contributor

skttl commented Nov 20, 2024

Which Contentment version are you using?

5.0.2

Which Umbraco version are you using? For example: 13.2.1 - don't just write v13

13.5.2

Bug summary

When using the default tag data source, it only finds cultureless tags. I have a site, where the tag fields are varying by culture. These tags doesn't show up, unless their specific culture is added as a parameter in GetAllTags, eg. tagQuery?.GetAllTags(tagGroup, "da-DK")

I don't know if there is a way to get the current editing culture and pass that into the list. That would probably help.

Steps to reproduce

Create a node with a tag field, set that field to vary by culture.
Add a data list with the tag source, and notice how tags added in the varied field doesn't show up.

Expected result / actual result

Expected tags to show up.

Do you have Umbraco ModelsBuilder enabled?

  • Yes, it is enabled.

What browsers are you seeing the problem on?

Chrome

@leekelleher
Copy link
Owner

Hey @skttl, thanks for raising this.

I fear that this may be unfixable for Data List (on Umbraco 13), as the data-sources aren't able to access the active variant/culture. I've come across this issue previously, some notes here: #396 (comment).

@leekelleher leekelleher added type/bug-report Something isn't working affected/v5 labels Nov 23, 2024
@leekelleher leekelleher added the help wanted Extra attention is needed label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected/v5 help wanted Extra attention is needed type/bug-report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants