Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupling from Underscore.js #39

Closed
leekelleher opened this issue Sep 3, 2020 · 4 comments · Fixed by #64
Closed

Decoupling from Underscore.js #39

leekelleher opened this issue Sep 3, 2020 · 4 comments · Fixed by #64
Assignees
Labels
help wanted Extra attention is needed
Milestone

Comments

@leekelleher
Copy link
Owner

leekelleher commented Sep 3, 2020

Taking lead from the Some decoupling from underscorejs #7731 ticket on the Umbraco CMS repo. I'd like Contentment to follow the same approach.

Also, relevant reading... You don't (may not) need Lodash/Underscore.

Using GitHub's search, these are the code files containing // TODO: Replace Underscore.js dependency. that I've littered throughout my codebase. https://github.com/leekelleher/umbraco-contentment/search?q=TODO+Underscore+dependency&unscoped_q=TODO+Underscore+dependency&type=Code

If anyone would like to help with this ticket, please don't interpret it as a whole task - any small incremental amends are warmly welcome.

@leekelleher leekelleher added the help wanted Extra attention is needed label Sep 3, 2020
@leekelleher leekelleher self-assigned this Sep 3, 2020
@greystate
Copy link
Contributor

Would the idea be the same as has been started for Umbraco (i.e., to replace Underscore with e.g. a Utilities object/class?)

@leekelleher
Copy link
Owner Author

Yes. I'm not sure which Umbraco version the Utilities helper is introduced in. (I assume 8.7.0, I'll check tomorrow). Either way, I'm happy to bump up the min version.

@leekelleher
Copy link
Owner Author

@greystate Confirmed that Utilities will be part of Umbraco 8.7.0. (ref: umbraco/Umbraco-CMS#7738)

Currently, Contentment is built against v8.6.1. I'm happy to bump this up to v8.7.0 once it is released, which would be for whatever the next Contentment version would be, either v1.1.x or v1.2.x.

I guess in the meantime, it's checking if there are any Underscore helpers used that could be replaced with native functions?

@Matthew-Wise Matthew-Wise mentioned this issue Dec 22, 2020
5 tasks
@leekelleher leekelleher linked a pull request Dec 22, 2020 that will close this issue
5 tasks
@leekelleher leekelleher added this to the 2.0.0 milestone Apr 15, 2021
@leekelleher
Copy link
Owner Author

Closing this ticket. It'll be covered (and any further discussion) on PR #64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants