Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxScale bug within estimateTissueBoundary function #7

Open
herrinca opened this issue Jan 3, 2022 · 0 comments
Open

maxScale bug within estimateTissueBoundary function #7

herrinca opened this issue Jan 3, 2022 · 0 comments

Comments

@herrinca
Copy link

herrinca commented Jan 3, 2022

Hello, I am giving your workflow a go and came across what I think is a bug.

Currently, if maxScale is set to 0 it will be changed to None at line 61 and on the next tile loop will be caught by the else statement (line 67) which trys to convert what is now None to a float at line 69. This returns a TypeError: float() argument must be a string or a number, not 'NoneType'. Simple fix might be to drop maxScale=None and change line 62 from using_mpl_scatter_density(fig, x['y'], x['x'],maxScale) to using_mpl_scatter_density(fig, x['y'], x['x'],None).

Best,
Chuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant