-
Notifications
You must be signed in to change notification settings - Fork 174
Replace Airbnb linting with prettier #18
Comments
@arvigeus I think Airbnb's linter provides more than just styling rules, it also checks for possible mistakes. Prettier in the other hand, only cares about how your code looks. |
I agree with @lucasmotta. I think there's a huge benefit to enforcing linting during the code process, not just afterwards. In bigger teams, it keeps everyone on the same page. In solo teams, it can pick up on obvious goofs like missing commas or uninitialised vars. The eslinter provided also dynamically checks propTypes on components and highlights if something is declared but not used, or vice versa. IMO, these are all invaluable coding aids that I would like to keep. As for prettier integration, where in the workflow do you think it should fit in? Since prettier outputs a uniform format, it's just as easy (and possibly more useful) to enable it in Atom or another IDE and get prettify-on-save functionality. I could add it as a step to Webpack to prettify on bundle, but then that only happens when you run a corresponding I'll keep this open to thoughts for now. Somewhat related to #19. |
Airbnb and Prettier disagree on some styling rules - for example 'string' vs "string" and can't be used together (or at least not in their current form) |
There's this that might be useful. Picking up code goofs and conforming code to a style would be perfect. |
I want to create a 'slim' version of the repo shortly that would not have any opinions as far as linting and stylistic choices, so it'd be up to the developer to add in things like prettier. I'll close this for now. |
Airbnb code guide is great, but developer's job is to focus on code, not on code styling. Prettier "just works" and produces nicely formatted code without forcing you to think about formatting.
The text was updated successfully, but these errors were encountered: