Upgrade pdf2image from 1.12.0 to 1.12.1

[Tlazypanda]

Summary

While setting up the project, the requirement pdf2image 1.12.0 version is not available as a distribution.On checking out their package link https://pypi.org/project/pdf2image/#history found out that the correct version should be 1.12.1.

Category

BUG

Screenshots

[Tlazypanda]

@kollivier @indirectlylit @benjaoming can you kindly approve this issue? Thanks ✌️

[benjaoming]

Hi @Tlazypanda - the version is already set to 1.12.1: https://github.com/learningequality/studio/blob/develop/requirements.txt#L96

What instruction were you following that gave you 1.12.0?

[Tlazypanda]

@benjaoming I followed the instructions given in the readme -

Ensure your environment matches the one specified in Pipfile.lock

pipenv sync --dev

[benjaoming]

Oh right - how on earth did that happen. Maybe @kollivier knows?

There is a non-existent PyPi release in Pipenv.lock

https://github.com/learningequality/studio/blob/develop/Pipfile.lock#L893

It was added by dependabot in this really weird update

2f3c7aa

Bots + Pipenv.lock = 😖

[kollivier]

I believe that somehow the pypi maintainer for pdf2image actually removed the 1.12.0 release and replaced it with 1.12.1, perhaps because there was a serious issue in the release, but for projects that pinned their dependencies when 1.12.0 still existed, this problem will happen.

We are in the process of switching from pipenv to pip-tools, and one of the reasons is that pipenv updates all non-pinned dependencies whenever you want to update or add a dependency, even when you ask it not to. I have tested that pip-tools works, but now I need to finish up the docs and Pipfile and Pipfile.lock removal, which I'm hoping to take care of this week.

In the meantime, things should work on develop branch if you do a pip install -r requirements.txt and pip install -r requirements-dev.txt instead of using pipenv.

[benjaoming]

I was going to say that you cannot delete packages on PyPi, but ay... that's actually possible. So definitely the right theory.

Bots + Pipenv.lock + package deletion = 😖

[rtibbles]

This issue is stale as it's been removed as a dependency.