Putting a number for school creates an invalid profile state

[willgearty]

If a student enters a number for the K12 school field, the profile form will submit fine. However, upon trying to submit the profile form again, it will then error with the following message:

K12School matching query does not exist.

My guess is that the form validation guesses that these numeric values correspond to a K12 School object, rather than just a string and then attempts to look up the object (but finds none).

[willgearty]

It's possible this is a broader issue related to AjaxForeignKeyNewformField:

ESP-Website/esp/esp/db/forms.py

Line 156 in b404807

class AjaxForeignKeyNewformField(forms.IntegerField):

[willgearty]

Indeed, it looks like the clean function takes this to be an object ID:

ESP-Website/esp/esp/db/forms.py

Lines 240 to 252 in b404807

	try:
	id = int(value)
	except ValueError:
	match = get_id_re.match(value)
	if match:
	id = int(match.groups()[0])
	else:
	# Reverted to standard behavior because some forms need their
	# AjaxForeignKey fields to be required. -Michael P 8/31/2009
	if self.required:
	raise forms.ValidationError('This field is required.')
	else:
	id = None

I think the easiest fix here might be to change the front end functionality so that when a number is manually entered, we make it clear that this isn't an autocomplete value:

ESP-Website/esp/esp/db/forms.py

Lines 58 to 97 in b404807

	javascript = """
	<script type="text/javascript">
	<!--
	$j(function () {
	$j("#id_%(fn)s").val("%(init_val)s");
	$j("#id_%(fn)s_data").val("%(data)s");
	$j("#id_%(fn)s").autocomplete({
	source: function(request, response) {
	$j.ajax({
	url: "/admin/ajax_autocomplete/",
	dataType: "json",
	data: {
	model_module: "%(model_module)s",
	model_name: "%(model_name)s",
	ajax_func: "%(ajax_func)s",
	ajax_data: request.term,
	prog: "%(prog)s",
	},
	success: function(data) {
	var output = $j.map(data.result, function(item) {
	return {
	label: item.ajax_str,
	value: item.ajax_str,
	id: item.id
	};
	});
	response(output);
	}
	});
	},
	select: function(event, ui) {
	$j("#id_%(fn)s_data").val(ui.item.id);
	%(shadow_field_javascript)s
	},
	change: function(event, ui) {
	$j("#id_%(fn)s_data").val(ui.item ? ui.item.id : null);
	$j("#id_%(shadow_field)s").val($j("#id_%(fn)s").val());
	}
	});
	});

Another option (probably easier) is to require that manual values are not only numbers (via regex maybe).

[willgearty]

Actually, I think an even easier change would be to use filter() and exists() here:

ESP-Website/esp/esp/db/forms.py

Lines 262 to 263 in b404807

	if id:
	return self.field.rel.to.objects.get(id=id)

If the object with that ID doesn't exist, then we should just return None (or raise an error if a proper value is required).