-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark the gson-java8-datatype dependency as optional #493
Comments
It used to be like this, but... people would just add Gson and it would work for a while until they'd use a "wrong" type and things would blow up... So I intentionally left the extra data types as "mandatory" hoping an astute developer would override that manually if they're bothered. |
I see where you're coming from, but I would still make it optional. We should however make an explicit mention that this library is required when using Gson rather than Jackson. On that note: Is it enough to add the Gson library to a project to use Gson over Jackson, or is additional configuration required? |
SPQR first checks for Jackson on the classpath and prefers that if available. If not, it checks for Gson, and uses that. generator.withValueMapperFactory(new GsonValueMapperFactory()) |
Since the Gson dependency itself is marked as optional we should also mark this library as optional.
The text was updated successfully, but these errors were encountered: