Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring MapToListTypeAdapter in line with the other adapters #382

Closed
kaqqao opened this issue Mar 10, 2021 · 0 comments
Closed

Bring MapToListTypeAdapter in line with the other adapters #382

kaqqao opened this issue Mar 10, 2021 · 0 comments

Comments

@kaqqao
Copy link
Member

kaqqao commented Mar 10, 2021 •
edited
Loading

The current implementation of the MapToListTypeAdapter produces GraphQL types directly, without delegating to OperationMapper. This has an unintended side effect of not triggering any SchemaTransformers, DirectiveBuilders etc.

This is technically a breaking change, but is highly unlikely to actually affect any user code.
@kaqqao kaqqao closed this as completed in bc5b928 Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaqqao