Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host.takeScreenshot & host.runProcess (do not) time out #724

Closed
creativecreatorormaybenot opened this issue Dec 31, 2022 · 3 comments
Closed
Labels
bug Something isn't working needs more info Looks valid, but more info is needed platform: ios iOS is affected

Comments

@creativecreatorormaybenot
Copy link
Contributor

When running this code from the examples:

await $.host.runProcess(
  'bash',
  arguments: ['-c', 'echo "hello world" > hello.txt'],
);

Or this code:

await $.host.takeScreenshot(name: '1_before_run');

On macOS on an iOS simulator using patrol drive, the tests continue running forever.
That is the screenshot is never taken (no file is generated) and the host process is never executed (does not take action).

It seems that this line:

final resp = await _controller.stream.firstWhere((r) => r.id == eventId);

Halts the tests forever. I did notice this comment:

// TODO: Add timeout after 10 sec

However, the process is also never executed. So adding a timeout would not fix the underlying problem in my case.

@bartekpacia
Copy link
Contributor

Hi! Thanks for reporting this issue.

I've just run patrol drive -t integration_test/process_test.dart (in the example app) and it worked (patrol 0.10.6, patrol_cli v0.8.1).

I'm going to keep this open but I cannot reproduce this. I'd be happy if we had more info on this.

@bartekpacia bartekpacia added platform: ios iOS is affected bug Something isn't working help wanted needs more info Looks valid, but more info is needed and removed help wanted labels Jan 4, 2023
@bartekpacia
Copy link
Contributor

This feature is no longer available because of our massive architectural change in #661.

We plan to bring it back sometime in the future, but it won't be in our 1.0 release.

See also:

@bartekpacia bartekpacia closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs more info Looks valid, but more info is needed platform: ios iOS is affected
Projects
None yet
Development

No branches or pull requests

2 participants