Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patrol test - assume FLAK tests to PASS #1181

Closed
bartekpacia opened this issue Apr 5, 2023 · 6 comments
Closed

patrol test - assume FLAK tests to PASS #1181

bartekpacia opened this issue Apr 5, 2023 · 6 comments
Labels
package: patrol_cli Related to the patrol_cli package

Comments

@bartekpacia
Copy link
Contributor

Requested by @fylyppo.

The tests in the project he works on are flaky.

He suggests adding a flag to patrol_cli to make FLAK tests become PASS:

203557831-a99f6fa4-f9be-419b-89b7-7c17cc619304

The tentative name for the flag: --ignore-flakes.

@bartekpacia
Copy link
Contributor Author

@fylyppo can't just use patrol test || true, because then the exit code would be 0 even if all tests failed.

@fylyppo
Copy link
Collaborator

fylyppo commented Apr 5, 2023

Maybe we can stay with FLAK output from test target (it gives me more info in tests summary) but let's change exit code for situation like:

PASS first_test.dart on emulator-5554
PASS second_test.dart on emulator-5554
PASS third_test.dart on emulator-5554
FLAK fourth_test.dart on emulator-5554
FLAK fifth_test.dart on emulator-5554

to be 0.

Reason: I have some listener for exit code and the goal is to know only about critical errors from test (only if test target fail every time).

@bartekpacia
Copy link
Contributor Author

Good idea - I like it.

@bartekpacia bartekpacia added tweak package: patrol_cli Related to the patrol_cli package labels Apr 5, 2023
@bartekpacia
Copy link
Contributor Author

bartekpacia commented Jun 9, 2023

The table summary with PASS/FLAK/FAIL is no longer available 2.0.
We might add it back later on - see #1028 for more.

Action item for @bartekpacia: Check how Gradle-generated and Xcode-generated reports look like with repeated tests: https://stackoverflow.com/questions/39193268/run-espresso-test-multiple-times
Action item for @fylyppo : Check if repeating tests N times works on Firebase Test Lab

@bartekpacia
Copy link
Contributor Author

This UI doesn't exist anymore since Patrol 2.0

@bartekpacia bartekpacia closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: patrol_cli Related to the patrol_cli package
Projects
None yet
Development

No branches or pull requests

2 participants