Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the add-on at addons.mozilla.org #13

Closed
gunesacar opened this issue May 23, 2022 · 3 comments
Closed

Publish the add-on at addons.mozilla.org #13

gunesacar opened this issue May 23, 2022 · 3 comments

Comments

@gunesacar
Copy link
Collaborator

Creating this issue to track the progress of publishing the add-on to AMO.
The code for that effort lives here: https://github.com/leaky-forms/leak-inspector/tree/development

@asumansenol
Copy link
Collaborator

asumansenol commented Jul 4, 2022

Add-on note: Unfortunately, LeakInspector will not be available on Firefox Add-on Store as our second application is also rejected due to modified third-party code usage. We used external code (coincidentally from Firefox) for a variety of reasons such as detecting input fields or getting eTLD+1’s from URLs. We had to make modifications so that the code works in an add-on setting. Mozilla, however, doesn’t allow modified third-party library usage since reviewers must be able to verify the code in the extensions. They first demanded that we remove minified, concatenated code from the add-on source and also they want us to provide the original sources together with instructions on how to generate the final XPI. We addressed all these requests and resubmitted our add-on on May 27, 2022. We’ve recently learned that our second attempt was also rejected. We’ve asked for suggestions, but haven’t gotten any response.

As a result, LeakInspector will not be available on the Firefox Add-on Store. While it's still possible to install the LeakInspector from the source code, we don’t recommend that for all users as explained here: #1 (comment)

@nukeop
Copy link

nukeop commented Jul 12, 2022

Can you just publish the xpi in github releases?

@gunesacar
Copy link
Collaborator Author

Thanks for the suggestion @nukeop

As discussed in #1 (comment) we are hesitant to make it easier to sideload our extension. Power users who are aware of the risks of installing XPIs from the web, can look into building the extension from source. Having said that, it's possible that we are overly cautious here. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants