Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe Instruction can become covered by Share Buttons #122

Closed
eiselems opened this issue Nov 24, 2015 · 3 comments
Closed

Swipe Instruction can become covered by Share Buttons #122

eiselems opened this issue Nov 24, 2015 · 3 comments
Milestone

Comments

@eiselems
Copy link
Collaborator

Bug: If post has less than about 4 paragraphs the swipe instruction is cover.

Reproduce: Remove a few lines in https://panossakkos.github.io/personal-jekyll-theme/tech/2015/06/27/welcome.html
Result:
image

@eiselems
Copy link
Collaborator Author

I just tried to apply z-index:1 to

<div id="swipe-instruction">
  • seems to work like it should.
    Can provide a fix later, just need to setup a sass environment.

@eiselems
Copy link
Collaborator Author

Update:

realized i don't need to compile anything by myself 😄

I only have no clue where to put that

#swipe-instruction {
    z-index: 1;
}

Should we create a new scss file for blog related styles?
Or where should it be placed?

@le4ker le4ker changed the title Swipe Instruction can become covered by Social Buttons Swipe Instruction can become covered by Share Buttons Nov 24, 2015
@le4ker le4ker added this to the 4.0.1 milestone Nov 24, 2015
@le4ker le4ker closed this as completed in 3efd4e2 Nov 24, 2015
@le4ker
Copy link
Owner

le4ker commented Nov 24, 2015

Well spotted! 😄

Check the fix commit to see the diff 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants