Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: PR 5259 (exptostd) #41

Closed
ldez opened this issue Dec 27, 2024 · 1 comment
Closed

benchmark: PR 5259 (exptostd) #41

ldez opened this issue Dec 27, 2024 · 1 comment

Comments

@ldez
Copy link
Owner

ldez commented Dec 27, 2024

{
"pr": 5259,
"linter": "exptostd"
}

Copy link

The benchmark (Benchmark PR (new linter)) is done!

beego/beego

Command Mean [ms] Min [ms] Max [ms] Relative
exptostd 870.5 ± 54.4 827.9 1005.2 1.68 ± 0.11
goconst 518.7 ± 6.9 508.4 527.7 1.00
durationcheck 851.9 ± 21.4 824.6 887.3 1.64 ± 0.05

cilium/cilium

Command Mean [s] Min [s] Max [s] Relative
exptostd 6.038 ± 0.078 5.926 6.153 2.01 ± 0.03
goconst 3.008 ± 0.025 2.971 3.044 1.00
durationcheck 6.017 ± 0.063 5.918 6.101 2.00 ± 0.03

spf13/cobra

Command Mean [ms] Min [ms] Max [ms] Relative
exptostd 347.6 ± 12.8 337.3 378.4 1.40 ± 0.05
goconst 248.0 ± 3.4 241.4 253.9 1.00
durationcheck 341.8 ± 5.6 336.8 355.7 1.38 ± 0.03

hashicorp/consul

agent/grpc-external/services/resource/write.go:206:15: golang.org/x/exp/maps.Clone() can be replaced by maps.Clone() (exptostd)
	inputCopy := maps.Clone(input.Metadata)
	             ^
agent/grpc-external/services/resource/write.go:207:18: golang.org/x/exp/maps.Clone() can be replaced by maps.Clone() (exptostd)
	existingCopy := maps.Clone(existing.Metadata)
	                ^
agent/grpc-external/services/resource/write.go:212:6: golang.org/x/exp/maps.Equal() can be replaced by maps.Equal() (exptostd)
	if !maps.Equal(inputCopy, existingCopy) {
	    ^
agent/grpc-external/services/resource/write.go:11:2: Import statement 'golang.org/x/exp/maps' can be replaced by 'maps' (exptostd)
	"golang.org/x/exp/maps"
	^
internal/resource/resourcetest/client.go:125:14: golang.org/x/exp/slices.ContainsFunc() can be replaced by slices.ContainsFunc() (exptostd)
				found := slices.ContainsFunc(written, func(id *pbresource.ID) bool {
				         ^
internal/resource/resourcetest/client.go:14:2: Import statement 'golang.org/x/exp/slices' can be replaced by 'slices' (exptostd)
	"golang.org/x/exp/slices"
	^
agent/structs/acl_templated_policy.go:302:7: golang.org/x/exp/slices.Contains() can be replaced by slices.Contains() (exptostd)
		if !slices.Contains(list[tp.TemplateName], *tp.TemplateVariables) {
		    ^
agent/structs/config_entry_gateways.go:1001:5: golang.org/x/exp/slices.Contains() can be replaced by slices.Contains() (exptostd)
	if slices.Contains(s[key], routeRef) {
	   ^
agent/xds/routes.go:515:4: golang.org/x/exp/slices.SortStableFunc() can be replaced by slices.SortStableFunc() (exptostd)
			slices.SortStableFunc(listenerRoute.VirtualHosts, func(a, b *envoy_route_v3.VirtualHost) int {
			^
agent/xds/routes.go:18:2: Import statement 'golang.org/x/exp/slices' can be replaced by 'slices' (exptostd)
	"golang.org/x/exp/slices"
	^
command/snapshot/save/snapshot_save.go:80:6: golang.org/x/exp/slices.Contains() can be replaced by slices.Contains() (exptostd)
		if slices.Contains(appendFileNameFlags, "version") {
		   ^
command/snapshot/save/snapshot_save.go:96:6: golang.org/x/exp/slices.Contains() can be replaced by slices.Contains() (exptostd)
		if slices.Contains(appendFileNameFlags, "dc") {
		   ^
command/snapshot/save/snapshot_save.go:9:2: Import statement 'golang.org/x/exp/slices' can be replaced by 'slices' (exptostd)
	"golang.org/x/exp/slices"
	^
Command Mean [s] Min [s] Max [s] Relative
exptostd 4.737 ± 0.034 4.692 4.802 1.86 ± 0.04
goconst 2.546 ± 0.048 2.517 2.681 1.00
durationcheck 4.747 ± 0.148 4.624 5.153 1.86 ± 0.07

go-delve/delve

Command Mean [ms] Min [ms] Max [ms] Relative
exptostd 880.7 ± 9.7 870.3 896.0 1.63 ± 0.03
goconst 541.2 ± 9.1 530.9 555.9 1.00
durationcheck 884.3 ± 19.9 872.6 938.6 1.63 ± 0.05

etcd-io/etcd

Command Mean [ms] Min [ms] Max [ms] Relative
exptostd 576.1 ± 8.7 559.5 593.8 1.79 ± 0.03
goconst 322.7 ± 3.9 317.2 328.6 1.00
durationcheck 586.4 ± 18.4 565.0 635.0 1.82 ± 0.06

go-gitea/gitea

Command Mean [s] Min [s] Max [s] Relative
exptostd 3.480 ± 0.058 3.421 3.622 1.91 ± 0.04
goconst 1.820 ± 0.026 1.798 1.880 1.00
durationcheck 3.485 ± 0.037 3.440 3.579 1.91 ± 0.03

google/go-github

Command Mean [s] Min [s] Max [s] Relative
exptostd 1.848 ± 0.068 1.780 2.016 2.36 ± 0.09
goconst 0.784 ± 0.012 0.770 0.810 1.00
durationcheck 1.859 ± 0.047 1.809 1.936 2.37 ± 0.07

golangci/golangci-lint

Command Mean [s] Min [s] Max [s] Relative
exptostd 1.048 ± 0.029 1.018 1.119 1.78 ± 0.05
goconst 0.588 ± 0.008 0.579 0.606 1.00
durationcheck 1.045 ± 0.010 1.030 1.057 1.78 ± 0.03

goreleaser/goreleaser

Command Mean [s] Min [s] Max [s] Relative
exptostd 1.755 ± 0.075 1.686 1.942 2.16 ± 0.10
goconst 0.811 ± 0.012 0.797 0.837 1.00
durationcheck 1.741 ± 0.018 1.709 1.767 2.15 ± 0.04

grpc/grpc-go

Command Mean [s] Min [s] Max [s] Relative
exptostd 1.637 ± 0.091 1.575 1.844 1.75 ± 0.10
goconst 0.936 ± 0.012 0.917 0.953 1.00
durationcheck 1.592 ± 0.020 1.557 1.625 1.70 ± 0.03

gohugoio/hugo

Command Mean [s] Min [s] Max [s] Relative
exptostd 2.290 ± 0.028 2.247 2.344 2.61 ± 0.04
goconst 0.879 ± 0.010 0.865 0.899 1.00
durationcheck 2.282 ± 0.033 2.256 2.369 2.60 ± 0.05

kubernetes/kubernetes

Command Mean [s] Min [s] Max [s] Relative
exptostd 9.469 ± 0.128 9.316 9.696 1.69 ± 0.03
goconst 5.596 ± 0.066 5.526 5.717 1.00
durationcheck 9.481 ± 0.100 9.341 9.655 1.69 ± 0.03

go-acme/lego

Command Mean [s] Min [s] Max [s] Relative
exptostd 2.016 ± 0.098 1.938 2.286 2.21 ± 0.11
goconst 0.912 ± 0.013 0.898 0.941 1.00
durationcheck 1.962 ± 0.015 1.939 1.982 2.15 ± 0.03

pact-foundation/pact-go

Command Mean [ms] Min [ms] Max [ms] Relative
exptostd 463.9 ± 10.1 447.7 481.6 1.60 ± 0.04
goconst 289.9 ± 2.5 285.9 294.3 1.00
durationcheck 461.1 ± 4.9 454.0 468.6 1.59 ± 0.02

rclone/rclone

Command Mean [s] Min [s] Max [s] Relative
exptostd 2.267 ± 0.089 2.201 2.479 1.78 ± 0.07
goconst 1.272 ± 0.009 1.254 1.286 1.00
durationcheck 2.255 ± 0.035 2.209 2.335 1.77 ± 0.03

hashicorp/terraform

Command Mean [s] Min [s] Max [s] Relative
exptostd 3.185 ± 0.068 3.128 3.352 1.97 ± 0.05
goconst 1.617 ± 0.014 1.598 1.642 1.00
durationcheck 3.175 ± 0.047 3.135 3.285 1.96 ± 0.03

traefik/traefik

Command Mean [s] Min [s] Max [s] Relative
exptostd 3.290 ± 0.124 3.187 3.624 2.67 ± 0.10
goconst 1.230 ± 0.011 1.217 1.247 1.00
durationcheck 3.282 ± 0.046 3.211 3.359 2.67 ± 0.04

You can find the workflow here:
https://github.com/ldez/golangci-lint-bench/actions/runs/12518341937

@ldez ldez closed this as completed Dec 27, 2024
@ldez ldez changed the title benchmark: PR 5259 (exptostd) 📜 benchmark: PR 5259 (exptostd) Jan 4, 2025
@ldez ldez changed the title 📜 benchmark: PR 5259 (exptostd) benchmark: PR 5259 (exptostd) Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant