Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: PR 5246 (formatters) #40

Closed
ldez opened this issue Dec 26, 2024 · 1 comment
Closed

benchmark: PR 5246 (formatters) #40

ldez opened this issue Dec 26, 2024 · 1 comment

Comments

@ldez
Copy link
Owner

ldez commented Dec 26, 2024

{
"pr": 5246,
"linter": "goimports",
"version": "v1.62.2"
}

Copy link

The benchmark (Benchmark PR (updated linter)) is done!

beego/beego

local
client/cache/file_test.go:20:1: File is not properly formatted (goimports)
	"github.com/stretchr/testify/assert"
^
server/web/router.go:18:1: File is not properly formatted (goimports)
	"context"
^
v1.62.2
client/cache/file_test.go:20: File is not `goimports`-ed (goimports)
	"github.com/stretchr/testify/assert"
server/web/router.go:18: File is not `goimports`-ed (goimports)
	"context"
Command Mean [s] Min [s] Max [s] Relative
local 1.640 ± 0.044 1.581 1.718 1.04 ± 0.04
v1.62.2 1.580 ± 0.047 1.518 1.662 1.00

cilium/cilium

Command Mean [s] Min [s] Max [s] Relative
local 11.486 ± 0.335 11.132 12.245 1.03 ± 0.04
v1.62.2 11.198 ± 0.272 10.912 11.882 1.00

spf13/cobra

Command Mean [ms] Min [ms] Max [ms] Relative
local 387.0 ± 4.7 378.9 395.1 1.09 ± 0.02
v1.62.2 356.0 ± 4.1 347.9 362.6 1.00

hashicorp/consul

local
command/troubleshoot/ports/troubleshoot_ports.go:9:1: File is not properly formatted (goimports)
	"github.com/hashicorp/consul/troubleshoot/ports"
^
acl/policy_ce.go:9:1: File is not properly formatted (goimports)
	"fmt"
^
agent/dns.go:11:1: File is not properly formatted (goimports)
	agentdns "github.com/hashicorp/consul/agent/dns"
^
agent/translate_addr.go:8:1: File is not properly formatted (goimports)
	"github.com/hashicorp/consul/internal/dnsutil"
^
agent/agent_endpoint_ce_test.go:10:1: File is not properly formatted (goimports)
	"github.com/stretchr/testify/require"
^
agent/dns_reverse_lookup_test.go:7:1: File is not properly formatted (goimports)
	"context"
^
agent/health_endpoint_ce_test.go:9:1: File is not properly formatted (goimports)
	"github.com/hashicorp/consul/testrpc"
^
agent/blockingquery/blockingquery_test.go:7:1: File is not properly formatted (goimports)
	"fmt"
^
agent/connect/authz_test.go:6:1: File is not properly formatted (goimports)
import (
^
agent/consul/rate/handler.go:11:1: File is not properly formatted (goimports)
	"github.com/hashicorp/consul/agent/metadata"
^
v1.62.2
acl/policy_ce.go:9: File is not `goimports`-ed (goimports)
	"fmt"
agent/xds/locality_policy.go:7: File is not `goimports`-ed (goimports)
	"fmt"
agent/consul/state/config_entry_sameness_group_ce_test.go:8: File is not `goimports`-ed (goimports)
import (
agent/consul/state/memdb_test.go:7: File is not `goimports`-ed (goimports)
	"fmt"
lib/cluster_test.go:7: File is not `goimports`-ed (goimports)
	"github.com/stretchr/testify/require"
command/operator/raft/transferleader/transfer_leader_test.go:7: File is not `goimports`-ed (goimports)
	"github.com/hashicorp/consul/agent"
	"github.com/mitchellh/cli"
agent/grpc-external/services/dns/server.go:9: File is not `goimports`-ed (goimports)
	agentdns "github.com/hashicorp/consul/agent/dns"
agent/connect/authz_test.go:6: File is not `goimports`-ed (goimports)
import (
agent/envoyextensions/builtin/property-override/structpatcher_test.go:8: File is not `goimports`-ed (goimports)
	"google.golang.org/protobuf/types/known/anypb"
agent/dns.go:11: File is not `goimports`-ed (goimports)
	agentdns "github.com/hashicorp/consul/agent/dns"
Command Mean [s] Min [s] Max [s] Relative
local 6.927 ± 0.108 6.776 7.165 1.00
v1.62.2 7.041 ± 0.245 6.733 7.409 1.02 ± 0.04

go-delve/delve

local
pkg/proc/native/cpuid/xsave_x86.go:11:1: File is not properly formatted (goimports)

^
pkg/logflags/logger.go:4:1: File is not properly formatted (goimports)
	"github.com/sirupsen/logrus"
^
v1.62.2
pkg/logflags/logger.go:4: File is not `goimports`-ed (goimports)
	"github.com/sirupsen/logrus"
pkg/proc/native/cpuid/xsave_x86.go:11: File is not `goimports`-ed (goimports)

Command Mean [s] Min [s] Max [s] Relative
local 1.080 ± 0.020 1.056 1.123 1.01 ± 0.04
v1.62.2 1.065 ± 0.041 1.017 1.151 1.00

etcd-io/etcd

Command Mean [ms] Min [ms] Max [ms] Relative
local 407.0 ± 7.5 398.6 423.5 1.06 ± 0.04
v1.62.2 382.3 ± 12.0 368.0 400.4 1.00

go-gitea/gitea

Command Mean [s] Min [s] Max [s] Relative
local 5.720 ± 0.086 5.593 5.921 1.00
v1.62.2 5.725 ± 0.118 5.608 5.967 1.00 ± 0.03

google/go-github

Command Mean [s] Min [s] Max [s] Relative
local 2.783 ± 0.074 2.730 2.985 1.02 ± 0.03
v1.62.2 2.741 ± 0.018 2.725 2.786 1.00

golangci/golangci-lint

Command Mean [s] Min [s] Max [s] Relative
local 1.100 ± 0.021 1.075 1.136 1.01 ± 0.05
v1.62.2 1.084 ± 0.050 1.040 1.196 1.00

goreleaser/goreleaser

Command Mean [s] Min [s] Max [s] Relative
local 1.313 ± 0.014 1.298 1.346 1.00
v1.62.2 1.318 ± 0.038 1.262 1.394 1.00 ± 0.03

grpc/grpc-go

Command Mean [s] Min [s] Max [s] Relative
local 2.671 ± 0.042 2.599 2.736 1.01 ± 0.05
v1.62.2 2.655 ± 0.120 2.566 2.988 1.00

gohugoio/hugo

local
resources/page/page_marshaljson.autogen.go:20:1: File is not properly formatted (goimports)
	"github.com/gohugoio/hugo/config"
^
resources/page/pagegroup_test.go:18:1: File is not properly formatted (goimports)
	"github.com/google/go-cmp/cmp"
^
tpl/internal/go_templates/fmtsort/sort_test.go:10:1: File is not properly formatted (goimports)
	"github.com/gohugoio/hugo/tpl/internal/go_templates/fmtsort"
^
tpl/internal/go_templates/texttemplate/exec.go:10:1: File is not properly formatted (goimports)
	"github.com/gohugoio/hugo/tpl/internal/go_templates/fmtsort"
^
tpl/internal/go_templates/texttemplate/template.go:8:1: File is not properly formatted (goimports)
	"github.com/gohugoio/hugo/tpl/internal/go_templates/texttemplate/parse"
^
v1.62.2
resources/page/page_marshaljson.autogen.go:20: File is not `goimports`-ed (goimports)
	"github.com/gohugoio/hugo/config"
resources/page/pagegroup_test.go:18: File is not `goimports`-ed (goimports)
	"github.com/google/go-cmp/cmp"
tpl/internal/go_templates/texttemplate/exec.go:10: File is not `goimports`-ed (goimports)
	"github.com/gohugoio/hugo/tpl/internal/go_templates/fmtsort"
	"github.com/gohugoio/hugo/tpl/internal/go_templates/texttemplate/parse"
tpl/internal/go_templates/texttemplate/template.go:8: File is not `goimports`-ed (goimports)
	"github.com/gohugoio/hugo/tpl/internal/go_templates/texttemplate/parse"
tpl/internal/go_templates/fmtsort/sort_test.go:10: File is not `goimports`-ed (goimports)
	"github.com/gohugoio/hugo/tpl/internal/go_templates/fmtsort"
Command Mean [s] Min [s] Max [s] Relative
local 2.290 ± 0.141 2.182 2.596 1.03 ± 0.08
v1.62.2 2.234 ± 0.094 2.136 2.397 1.00

kubernetes/kubernetes

local
pkg/apis/apps/install/install.go:26:1: File is not properly formatted (goimports)
	"k8s.io/kubernetes/pkg/apis/apps/v1"
^
pkg/apis/authentication/install/install.go:26:1: File is not properly formatted (goimports)
	"k8s.io/kubernetes/pkg/apis/authentication/v1"
^
pkg/apis/authorization/install/install.go:26:1: File is not properly formatted (goimports)
	"k8s.io/kubernetes/pkg/apis/authorization/v1"
^
pkg/apis/autoscaling/install/install.go:26:1: File is not properly formatted (goimports)
	"k8s.io/kubernetes/pkg/apis/autoscaling/v1"
^
pkg/apis/batch/install/install.go:26:1: File is not properly formatted (goimports)
	"k8s.io/kubernetes/pkg/apis/batch/v1"
^
pkg/apis/core/v1/register.go:20:1: File is not properly formatted (goimports)
	"k8s.io/api/core/v1"
^
pkg/apis/events/install/install.go:26:1: File is not properly formatted (goimports)
	"k8s.io/kubernetes/pkg/apis/events/v1"
^
pkg/apis/policy/install/install.go:26:1: File is not properly formatted (goimports)
	"k8s.io/kubernetes/pkg/apis/policy/v1"
^
pkg/apis/rbac/install/install.go:26:1: File is not properly formatted (goimports)
	"k8s.io/kubernetes/pkg/apis/rbac/v1"
^
pkg/apis/scheduling/fuzzer/fuzzer.go:20:1: File is not properly formatted (goimports)
	"github.com/google/gofuzz"
^
v1.62.2
pkg/controller/volume/protectionutil/utils_test.go:22: File is not `goimports`-ed (goimports)
	"k8s.io/api/core/v1"
pkg/controller/deployment/progress.go:26: File is not `goimports`-ed (goimports)
	"k8s.io/api/core/v1"
pkg/controller/deployment/recreate.go:20: File is not `goimports`-ed (goimports)
	"context"
test/integration/configmap/configmap_test.go:25: File is not `goimports`-ed (goimports)
	"k8s.io/api/core/v1"
pkg/kubelet/stats/pidlimit/pidlimit.go:20: File is not `goimports`-ed (goimports)
	"k8s.io/api/core/v1"
pkg/controller/replicaset/replica_set_utils_test.go:27: File is not `goimports`-ed (goimports)
	"k8s.io/api/core/v1"
pkg/kubelet/apis/podresources/client.go:28: File is not `goimports`-ed (goimports)
	"k8s.io/kubelet/pkg/apis/podresources/v1"
pkg/kubelet/apis/podresources/server_v1alpha1.go:24: File is not `goimports`-ed (goimports)
	"k8s.io/kubelet/pkg/apis/podresources/v1"
pkg/kubelet/container/container_hash_test.go:23: File is not `goimports`-ed (goimports)
	"k8s.io/api/core/v1"
pkg/kubelet/configmap/configmap_manager_test.go:26: File is not `goimports`-ed (goimports)
	"k8s.io/api/core/v1"
Command Mean [s] Min [s] Max [s] Relative
local 16.629 ± 0.119 16.525 16.920 1.00
v1.62.2 16.673 ± 0.122 16.548 16.992 1.00 ± 0.01

go-acme/lego

Command Mean [s] Min [s] Max [s] Relative
local 2.002 ± 0.115 1.898 2.182 1.05 ± 0.06
v1.62.2 1.904 ± 0.017 1.881 1.926 1.00

pact-foundation/pact-go

local
doc.go:6:1: File is not properly formatted (goimports)
Consumer Tests
^
message/v3/asynchronous_message.go:194:1: File is not properly formatted (goimports)
//
^
v1.62.2
message/v3/asynchronous_message.go:194: File is not `goimports`-ed (goimports)
//
doc.go:6: File is not `goimports`-ed (goimports)
Consumer Tests
Command Mean [ms] Min [ms] Max [ms] Relative
local 724.4 ± 13.5 700.1 747.5 1.07 ± 0.04
v1.62.2 680.1 ± 23.9 648.5 717.3 1.00

rclone/rclone

Command Mean [s] Min [s] Max [s] Relative
local 3.714 ± 0.080 3.648 3.914 1.01 ± 0.03
v1.62.2 3.667 ± 0.055 3.596 3.765 1.00

hashicorp/terraform

Command Mean [s] Min [s] Max [s] Relative
local 5.937 ± 0.164 5.744 6.301 1.01 ± 0.05
v1.62.2 5.878 ± 0.206 5.652 6.309 1.00

traefik/traefik

Command Mean [s] Min [s] Max [s] Relative
local 2.478 ± 0.069 2.403 2.656 1.02 ± 0.03
v1.62.2 2.433 ± 0.043 2.379 2.530 1.00

You can find the workflow here:
https://github.com/ldez/golangci-lint-bench/actions/runs/12506239484

@ldez ldez closed this as completed Dec 26, 2024
@ldez ldez changed the title benchmark: PR 5246 (formatters) 🏷️ benchmark: PR 5246 (formatters) Jan 4, 2025
@ldez ldez changed the title 🏷️ benchmark: PR 5246 (formatters) benchmark: PR 5246 (formatters) Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant