fix: CDATA end in attributes must not cause an error

lddubeau · Aug 31, 2018 · a7495ac · a7495ac
1 parent 283bcfe
commit a7495ac
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 6 deletions.
diff --git a/lib/saxes.js b/lib/saxes.js
@@ -1384,9 +1384,6 @@ class SaxesParser {
       this.fail("disallowed character.");
     }
     else if (c) {
-      if (this.attribValue.includes("]]>")) {
-        this.fail("the string \"]]>\" is disallowed in char data.");
-      }
       this.attribList.push({ name: this.name, value: this.attribValue });
       this.name = this.attribValue = "";
       this.q = null;

diff --git a/test/cdata-fake-end.js b/test/cdata-fake-end.js
@@ -1,6 +1,8 @@
 "use strict";
 
-require(".").test({
+const { test } = require(".");
+
+test({
   name: "cdata fake end",
   expect: [
     ["opentagstart", { name: "r", attributes: {} }],
@@ -17,7 +19,7 @@ require(".").test({
   },
 });
 
-require(".").test({
+test({
   name: "cdata fake end 2",
   expect: [
     ["opentagstart", { name: "r", attributes: {} }],

diff --git a/test/cdata.js b/test/cdata.js
@@ -1,6 +1,8 @@
 "use strict";
 
-require(".").test({
+const { test } = require(".");
+
+test({
   name: "cdata",
   xml: "<r><![CDATA[ this is character data  ]]><![CDATA[]]></r>",
   expect: [
@@ -11,3 +13,25 @@ require(".").test({
     ["closetag", { name: "r", attributes: {}, isSelfClosing: false }],
   ],
 });
+
+test({
+  name: "cdata end in attribute",
+  expect: [
+    ["opentagstart", { name: "r", attributes: {} }],
+    ["opentag", {
+      name: "r",
+      attributes: {
+        foo: "]]>",
+      },
+      isSelfClosing: true,
+    }],
+    ["closetag", {
+      name: "r",
+      attributes: {
+        foo: "]]>",
+      },
+      isSelfClosing: true,
+    }],
+  ],
+  xml: "<r foo=']]>'/>",
+});