-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bf:generationDate domain should be bf:GenerationProcess #117
Comments
this generation date property hasn't changed since 2016:
But you are right; it's not inside GenerationProcess.
Maybe it should be? It's arguably about the generation process. |
I put the example from my link above - it seems like fix is to remove the domain or change it to bf:GenerationProcess. These examples are a huge improvement, thanks for doing this! BIBFRAME is a lot closer to MARC now that it was back in 2016. In this case, in bibframe2marc the label is the 884$a, generated by marc2bibframe2, the bf:generationDate is the 884$g date is a timestamp generated by the marc2bibframe2 conversion, the local identifier 884$k and the 884$q value are external parameters which are used by bibframe2marc. This shape makes sense but doesn't really translate to OWL or SHACL - maybe you can add a comment about the shape. |
I was under the impression the purpose of generationDate was that it could be used alongside a linked GenerationProcess [1]. If the need is to make this construction more annotation-like you could also simply use the regular date property [2]? Example 1
Example 2
|
See https://id.loc.gov/ontologies/bibframe.html#p_generationDate
The example has:
But the ontology has
<rdfs:domain rdf:resource="http://id.loc.gov/ontologies/bibframe/AdminMetadata"/>
We had corrected GenerationProcess so it wasn't a subclass of AdminMetadata but this property didn't get updated - it should be<rdfs:domain rdf:resource="http://id.loc.gov/ontologies/bibframe/GenerationProcess"/>
(or no domain...)I would suggest changing the example so it uses the same example as the property/class e.g.https://id.loc.gov/ontologies/bibframe.html#p_generationProcess.
The text was updated successfully, but these errors were encountered: