Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add settings api (#191) (#211) #212

Merged
merged 1 commit into from
Jul 2, 2020
Merged

feat: add settings api (#191) (#211) #212

merged 1 commit into from
Jul 2, 2020

Conversation

jduo
Copy link
Contributor

@jduo jduo commented Jul 2, 2020

Restore and re-implement LCUIDisplay_EnablePaintFlashing().

Fixes #191

Changes proposed in this pull request:

  • Add back LCUIDisplay_EnablePaintFlashing()
  • Reimplement to set this field on the settings API, which notifies the display module.

@lc-soft

@jduo
feat: add settings api (lc-soft#191) (lc-soft#211)
e1d5849 
Restore and re-implement LCUIDisplay_EnablePaintFlashing.

Fixes lc-soft#191
@commit-lint
Copy link

commit-lint bot commented Jul 2, 2020

Features

Contributors

@jduo

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@jduo jduo mentioned this pull request Jul 2, 2020
Merged
lc-soft
lc-soft approved these changes Jul 2, 2020
View reviewed changes
Copy link
Owner

@lc-soft lc-soft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@lc-soft lc-soft merged commit 94be958 into lc-soft:develop Jul 2, 2020
lc-soft pushed a commit that referenced this pull request Jul 2, 2020
@jduo @lc-soft
feat: add settings api (#191) (#211) (#212)
1b8c6e6 
- Add API for retrieving and modifying global settings
- Utilize this API in the codebase
- Add event for when global settings are changed
- Add event handler for updating the frame rate cap
- Add event handler to notify paint flashing changes
- Add unit tests

Fixes #192

Co-authored-by: James Duong <[email protected]>

feat: add settings api (#191) (#211) (#212)

Restore and re-implement LCUIDisplay_EnablePaintFlashing.

Fixes #191
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lc-soft lc-soft lc-soft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom settings
2 participants
@jduo @lc-soft