Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project2 - comments #2

Open
LucasWaelti opened this issue May 3, 2019 · 0 comments
Open

Project2 - comments #2

LucasWaelti opened this issue May 3, 2019 · 0 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@LucasWaelti
Copy link
Collaborator

Proposed changes

  • test.py does not initialize Adam correctly (missing arguments).
  • In test.py, instance of DLModule should not be named nn but model instead. The NeuralNet module could be renamed nn to remain consistent with PyTorch.
  • Should only import torch.empty instead of torch to avoid name conflicts with the framework. This is required!
  • Add the line torch.set_grad_enabled( False ) to ensure that we are not using builtin torch functionalities.
@LucasWaelti LucasWaelti added the invalid This doesn't seem right label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants