From 2cd9b1c271559b5ae3563486194afd9cf35e51e5 Mon Sep 17 00:00:00 2001 From: Abhishek kr Date: Fri, 2 Jun 2023 02:04:26 +0530 Subject: [PATCH 1/6] Extend the resolution to 1920*1080 Signed-off-by: Abhishek kr --- cypress-action/cypress/support/commands.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress-action/cypress/support/commands.js b/cypress-action/cypress/support/commands.js index 18d71f4..722d7d2 100644 --- a/cypress-action/cypress/support/commands.js +++ b/cypress-action/cypress/support/commands.js @@ -56,7 +56,7 @@ Cypress.Commands.add("interceptCapabilities", () => { }) Cypress.Commands.add("setViewPort", () => { - cy.viewport(1500, 900) + cy.viewport(1920, 1080) }) Cypress.Commands.add("deleteDesign", (designId) => { From 446f2215aa3a79778b05e825bfb8dfd7a2f265dd Mon Sep 17 00:00:00 2001 From: Abhishek kr Date: Fri, 2 Jun 2023 02:29:33 +0530 Subject: [PATCH 2/6] direct to the meshery-cloud catalog page Signed-off-by: Abhishek kr --- action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/action.yml b/action.yml index 7db7900..304a7f6 100644 --- a/action.yml +++ b/action.yml @@ -121,5 +121,5 @@ runs: repository: "${{env.ORGANIZATION}}/${{env.REPOSITORY}}" number: ${{ inputs.prNumber }} id: meshmap-snapshot - message: "![github-ss](${{env.RESOURCE_URL}})" - append: false + message: "](https://meshery.layer5.io/catalog/applications)" + append: false \ No newline at end of file From 071ff04b886b748eca71c8d81b622277b2d48aa5 Mon Sep 17 00:00:00 2001 From: Abhishek kr Date: Fri, 2 Jun 2023 02:31:52 +0530 Subject: [PATCH 3/6] direct to the meshery-cloud catalog page Signed-off-by: Abhishek kr --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 304a7f6..5f2e43c 100644 --- a/action.yml +++ b/action.yml @@ -121,5 +121,5 @@ runs: repository: "${{env.ORGANIZATION}}/${{env.REPOSITORY}}" number: ${{ inputs.prNumber }} id: meshmap-snapshot - message: "](https://meshery.layer5.io/catalog/applications)" + message: '](https://meshery.layer5.io/catalog/applications)' append: false \ No newline at end of file From c169d506c4d92b2652ac5885ebd3bc220b860a21 Mon Sep 17 00:00:00 2001 From: Abhishek kr Date: Fri, 2 Jun 2023 02:34:06 +0530 Subject: [PATCH 4/6] put the PR reference dynamically Signed-off-by: Abhishek kr --- .github/workflows/pr-target-test.yml | 6 +++++- .github/workflows/test.yml | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-target-test.yml b/.github/workflows/pr-target-test.yml index b628142..9c2cff4 100644 --- a/.github/workflows/pr-target-test.yml +++ b/.github/workflows/pr-target-test.yml @@ -14,6 +14,10 @@ jobs: continue-on-error: true name: Run the MeshMap screenshot service steps: + - name: Set PR number + run: | + export pull_number=$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH") + echo "PULL_NO=$pull_number" >> $GITHUB_ENV - uses: actions/checkout@v3 - id: test_result uses: ./ @@ -22,4 +26,4 @@ jobs: providerToken: ${{ secrets.PROVIDER_TOKEN }} cypressRecordKey: ${{ secrets.CYPRESS_RECORD_KEY }} applicationId: c791ec8f-ec1a-47c1-b606-d39982e42ca6 - prNumber: 11 \ No newline at end of file + prNumber: ${{ env.PULL_NO }} \ No newline at end of file diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 45ef0cc..03cd2ba 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -11,6 +11,10 @@ jobs: test: # make sure the action works on a clean machine without building runs-on: ubuntu-latest steps: + - name: Set PR number + run: | + export pull_number=$(jq --raw-output .pull_request.number "$GITHUB_EVENT_PATH") + echo "PULL_NO=$pull_number" >> $GITHUB_ENV - uses: actions/checkout@v3 - id: test_result uses: ./ @@ -20,4 +24,4 @@ jobs: providerToken: ${{ secrets.PROVIDER_TOKEN }} cypressRecordKey: ${{ secrets.CYPRESS_RECORD_KEY }} applicationId: c791ec8f-ec1a-47c1-b606-d39982e42ca6 - prNumber: 11 + prNumber: ${{ env.PULL_NO }} From 196dc772be9dd76971e7d835104720f393c67934 Mon Sep 17 00:00:00 2001 From: Abhishek Kumar Date: Fri, 2 Jun 2023 02:38:42 +0530 Subject: [PATCH 5/6] Update cypress-action/cypress/support/commands.js --- cypress-action/cypress/support/commands.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress-action/cypress/support/commands.js b/cypress-action/cypress/support/commands.js index 722d7d2..788b2fa 100644 --- a/cypress-action/cypress/support/commands.js +++ b/cypress-action/cypress/support/commands.js @@ -56,7 +56,7 @@ Cypress.Commands.add("interceptCapabilities", () => { }) Cypress.Commands.add("setViewPort", () => { - cy.viewport(1920, 1080) + cy.viewport(1600, 950) }) Cypress.Commands.add("deleteDesign", (designId) => { From 94abae27f0d4ffcf83bc17a0a83403f6910d4833 Mon Sep 17 00:00:00 2001 From: Abhishek kr Date: Fri, 2 Jun 2023 02:43:12 +0530 Subject: [PATCH 6/6] minor Signed-off-by: Abhishek kr --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 5f2e43c..cf73143 100644 --- a/action.yml +++ b/action.yml @@ -121,5 +121,5 @@ runs: repository: "${{env.ORGANIZATION}}/${{env.REPOSITORY}}" number: ${{ inputs.prNumber }} id: meshmap-snapshot - message: '](https://meshery.layer5.io/catalog/applications)' + message: '[](https://meshery.layer5.io/catalog/applications)' append: false \ No newline at end of file