Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Disabled Javascript in Getnighthawk #186

Closed
AnshumanDhiman opened this issue Sep 30, 2021 · 2 comments · Fixed by #187
Closed

Add Disabled Javascript in Getnighthawk #186

AnshumanDhiman opened this issue Sep 30, 2021 · 2 comments · Fixed by #187
Assignees
@AnshumanDhiman
Labels
hacktoberfest kind/bug Something isn't working

Comments

@AnshumanDhiman
Copy link
Member

Description

Currently there's no notice for getnighthawk if javascript is disabled. When it is disabled it creating issues for website to run properly

Expected Behavior

A proper warning or notification type must appear at top showing that javascript is disabled

Screenshots

Environment:

  • OS: [e.g. Ubuntu]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 22]
  • Device: [e.g. laptop, iPhone 8]

[Optional] To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

[Optional] Additional Context

Contributor Resources
@AnshumanDhiman AnshumanDhiman added the kind/bug Something isn't working label Sep 30, 2021
@AnshumanDhiman
Copy link
Member Author

Can I work on this ?

@AnshumanDhiman AnshumanDhiman mentioned this issue Sep 30, 2021
Merged
1 task
@AnshumanDhiman
Copy link
Member Author

Hi can anyone review and merge this PR ??
ps :- if satisfied after merging please add hacktober-accepted tag😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnshumanDhiman AnshumanDhiman

Labels
hacktoberfest kind/bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a no-script in the site giving jungle green having a catchy loo… AnshumanDhiman/getnighthawk
1 participant
@AnshumanDhiman