Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker container build #20

Open
lawndoc opened this issue Jul 3, 2022 · 0 comments
Open

Fix Docker container build #20

lawndoc opened this issue Jul 3, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lawndoc
Copy link
Owner

lawndoc commented Jul 3, 2022

Don't pass environment variables to the container at build time... This is a security issue because it will put secrets in the container images. Only supply them at runtime.

There is no impact to my repo secrets because they are all used in ephemeral environments for automated testing and will not be used in production.

@lawndoc lawndoc added the bug Something isn't working label Jul 3, 2022
@lawndoc lawndoc added this to the v0.1 milestone Jul 3, 2022
@lawndoc lawndoc self-assigned this Jul 3, 2022
@lawndoc lawndoc moved this to Implementing in Commander v0.1 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Implementing
Development

No branches or pull requests

1 participant