Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make updateJob more like newJob #2

Open
lawndoc opened this issue Nov 11, 2021 · 1 comment
Open

make updateJob more like newJob #2

lawndoc opened this issue Nov 11, 2021 · 1 comment
Assignees
@lawndoc
Labels
redesign Adds a breaking change between versions
Milestone
v0.1

Comments

@lawndoc
Copy link
Owner

lawndoc commented Nov 11, 2021

newJob requires the upload of an entire job document in the request body. I'd like updateJob to require the same thing. That's not how I initially implemented it, but I'd like to change it now for consistency between HTTP methods on the same API endpoint.
@lawndoc lawndoc self-assigned this Nov 11, 2021
@lawndoc lawndoc added the redesign Adds a breaking change between versions label Nov 11, 2021
@lawndoc lawndoc added this to the v1.0 milestone Nov 11, 2021
@lawndoc lawndoc moved this to Backlog in Commander v0.1 Mar 18, 2022
@lawndoc
Copy link
Owner Author

lawndoc commented Mar 18, 2022

This would be a breaking change for the endpoint so I'm going to need to make sure this gets implemented in v1.0

@lawndoc lawndoc removed this from Commander v0.1 Mar 19, 2022
@lawndoc lawndoc moved this to Researching in Commander v0.1 Mar 19, 2022
@lawndoc lawndoc moved this from Researching to Backlog in Commander v0.1 Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawndoc lawndoc

Labels
redesign Adds a breaking change between versions
Projects
Commander v0.1
Status: Backlog
Milestone
v0.1
Development

No branches or pull requests
1 participant
@lawndoc