Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yahoo Finance should be updated again #76

Closed
leeschmalz opened this issue Jun 3, 2024 · 7 comments
Closed

Yahoo Finance should be updated again #76

leeschmalz opened this issue Jun 3, 2024 · 7 comments

Comments

@leeschmalz
Copy link

leeschmalz commented Jun 3, 2024

this api call fails with the current version:
stock.quotes = await yfinance2.quoteSummary(symbols[i], {modules: ['price']});

should be updated to version 2.11.3

see discussion: gadicc/node-yahoo-finance2#764

@lavolp3
Copy link
Owner

lavolp3 commented Jun 3, 2024

I have pushed a force to yfinance2 api v. 2.11.3

Please update:

git pull
npm install

and let me know if it works.

Thanks!

@leeschmalz
Copy link
Author

I am running master branch, updating locally to 2.11.3 worked for me. it looks like your push was to "yfinance" branch, which contains other changes that I have not tested.

@rmcelwee
Copy link

rmcelwee commented Jun 4, 2024

This did NOT fix it for me:
git pull
npm install

This DID fix it. Thanks again for a great module and the help to keep it running!
rm -r node_modules
rm package-lock.json
git pull
npm install

@jmslln
Copy link

jmslln commented Jun 5, 2024

I was seeing this in the log:
[2024-06-05 12:56:33.703] [LOG] MMM-AVStock: Error: Unsupported redirect to https://finance.yahoo.com/quote/AAPL/, please report.
at /home/pi/MagicMirror/modules/MMM-AVStock/node_modules/yahoo-finance2/dist/cjs/src/lib/getCrumb.js:103:23
at Generator.next ()
at fulfilled (/home/pi/MagicMirror/modules/MMM-AVStock/node_modules/yahoo-finance2/dist/cjs/src/lib/getCrumb.js:5:58)
at process.processTicksAndRejections (node:internal/process/task_queues:95
:5)

the advice from rmcelwee worked for me - thanks to both of you for keeping this module active

@lavolp3
Copy link
Owner

lavolp3 commented Jun 5, 2024

I am running master branch, updating locally to 2.11.3 worked for me. it looks like your push was to "yfinance" branch, which contains other changes that I have not tested.

This is right. I need to push the yfinance branch then it works how I described. Will do this tonight.

@lavolp3
Copy link
Owner

lavolp3 commented Jun 17, 2024

2 weeks late but has been pushed now. Closing this as resolved.

@lavolp3 lavolp3 closed this as completed Jun 17, 2024
@JATINMOUR
Copy link

Screenshot 2024-09-08 141319

anyone can help me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants