Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible division by zero #720

Open
Bbulatov opened this issue Nov 29, 2024 · 1 comment
Open

Possible division by zero #720

Bbulatov opened this issue Nov 29, 2024 · 1 comment
Labels

Comments

@Bbulatov
Copy link

Hello!
During the static analysis was found possible mistake in code:

  1. In oracle_fdw/oracle_gis.c:789 the condition may not be satisfied and then the function will return 0/1000 = 0 in oracle_fdw/oracle_gis.c:791. This value is then used, for example, in oracle_gis.c:969, which can lead to division by 0. Please clarify whether 0 is reached and whether this requires any changes?
    изображение
@laurenz
Copy link
Owner

laurenz commented Nov 29, 2024

That looks questionable, less.
But I don't know that code; it was contributed by @vmora more than a decade ago.
So far, I have not had any error reports about division by zero there, so it might be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants