Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to auto-detect external editor exit #842

Closed
tsumare opened this issue Oct 3, 2018 · 4 comments
Closed

Provide option to auto-detect external editor exit #842

tsumare opened this issue Oct 3, 2018 · 4 comments
Labels
desktop All desktop platforms enhancement Feature requests and code enhancements

Comments

@tsumare
Copy link

tsumare commented Oct 3, 2018

Operating system

  • Windows
  • macOS
  • Linux

Application

  • Desktop

Request

Provide an option which will automatically detect when a compatible external editor has exited and finalize the updates automatically without further user interaction.

vim/gvim for instance provides the -f flag to support this type of behavior. It is quite likely other editors can be configured in a similar manner. Allowing the option of enabling this sort of check will streamline the user experience somewhat as far as external editing is concerned.

       -f          Foreground.   For  the  GUI  version, Vim will not fork and 
                   detach from the shell it was started in.  On the Amiga, Vim 
                   is  not restarted to open a new window.  This option should 
                   be used when Vim is executed by a program  that  will  wait 
                   for  the  edit session to finish (e.g. mail).  On the Amiga 
                   the ":sh" and ":!" commands will not work.                  
@laurent22
Copy link
Owner

What would be the benefit of this option? Currently if you open a note in an external editor and close it, you go back to Joplin and you can switch notes, keep editing the note, etc. There's nothing blocking, so I'm wondering what would be the goal of this feature?

@tsumare
Copy link
Author

tsumare commented Oct 4, 2018

I had noticed that the icon changes to a "waiting" state when I open the editor, but doesn't notice when I closed it unless I click it again. I was worried that if I forgot to turn it back off or went back to editing the contents of the note directly something might not save or end up getting out of sync. (I tend to only use an external editor for more complex replacements or reformatting.) If this isn't the case, then I apologize for my confusion, and you can simply close this issue. Thanks

@laurent22
Copy link
Owner

Yes the note is actually saved regardless of the waiting state and whether you click on the button or not.

I'm going to remove the state from the button actually as it doesn't provide useful information, and can indeed be confusing.

@laurent22 laurent22 added enhancement Feature requests and code enhancements essential desktop All desktop platforms and removed question labels Oct 5, 2018
@laurent22
Copy link
Owner

External edition has been improved in the latest release.

@lock lock bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
desktop All desktop platforms enhancement Feature requests and code enhancements
Projects
None yet
Development

No branches or pull requests

2 participants