Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Functionality Issue in v2.10.2 #7486

Closed
godylockz opened this issue Dec 19, 2022 · 5 comments
Closed

Search Functionality Issue in v2.10.2 #7486

godylockz opened this issue Dec 19, 2022 · 5 comments
Labels
bug It's a bug desktop All desktop platforms high High priority issues

Comments

@godylockz
Copy link

BUG

In v2.10.2, when using the keyboard shortcut CTRL+F, it opens the search bar (below note window). However when typing afterwards, the typing focus is still inside the note not in the search bar (below note window).

Solution

Change the focus back to the search bar for typing after CTRL+F is pressed to type directly after when searching within the note.

@godylockz godylockz added the bug It's a bug label Dec 19, 2022
@laurent22
Copy link
Owner

OS?

@godylockz
Copy link
Author

OS?

Windows 11 sorry about that!

@laurent22 laurent22 added desktop All desktop platforms high High priority issues labels Dec 19, 2022
@sanskarfc
Copy link

reproduced in macOS too.

Seems to be weird. I would like to work on this bug for some time 👍

@sanskarfc
Copy link

Is this code snippet relevant to this issue?

export const declaration: CommandDeclaration = {
name: 'search',
iconName: 'icon-search',
};
export const runtime = (): CommandRuntime => {
return {
execute: async () => {
// Doesn't do anything for now but could be used to
// automatically focus the search field (using the
// `focusSearch` command) and then set an initial search.
// However not straightforward to implement since the SearchBar
// is not a controlled component.
},
};
};

@laurent22
Copy link
Owner

laurent22 commented Dec 22, 2022

Duplicate of #7520

@laurent22 laurent22 marked this as a duplicate of #7519 Dec 22, 2022
@laurent22 laurent22 marked this as a duplicate of #7520 Dec 22, 2022
@laurent22 laurent22 marked this as not a duplicate of #7519 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms high High priority issues
Projects
None yet
Development

No branches or pull requests

3 participants