Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The postion of input box is wrong when using Chinese input method #4347

Open
fintfire opened this issue Jan 12, 2021 · 9 comments
Open

The postion of input box is wrong when using Chinese input method #4347

fintfire opened this issue Jan 12, 2021 · 9 comments
Labels
bug It's a bug desktop All desktop platforms upstream There's a problem with upstream code.

Comments

@fintfire
Copy link

fintfire commented Jan 12, 2021

When inputting Chinese in Joplin,the postion of input box is wrong, covering the input text.
About three different input methods have been tested, including microsoft PinYin. All have the same problem.

Environment

Joplin version:
Joplin 1.6.7 (prod, win32)
客户端 ID: 9ff9abdc48cf4bf1b0c2d0bddc3c3fe2
同步版本: 2
配置文件版本: 34
支持的密钥链: 是
修订: b74b849 (master)

Platform:
Windows 10 20H2 19042.685

snaphot:

image

@fintfire fintfire added the bug It's a bug label Jan 12, 2021
@laurent22 laurent22 added desktop All desktop platforms high High priority issues labels Jan 12, 2021
@fintfire
Copy link
Author

Add a supplement: In note viewer, the position of input box is OK.

Snapshot:
joplin

@CalebJohn
Copy link
Collaborator

Do you mind testing this issue here. That will tell us if the issue is with Joplin, or the editor component that Joplin uses (CodeMirror).

@fintfire
Copy link
Author

I'm not familiar with web development,then test it at https://codesandbox.io/s/codemirror-test-pfdfj.
No problem.

joplin

@CalebJohn
Copy link
Collaborator

@flintning I'm sorry for getting back so late.
But could you test here instead? The editor you tested on is Monaco, not CodeMirror.

@fintfire
Copy link
Author

I've test your URL. The overlapping problem also existed but much better than Joplin.
joplin

@laurent22 laurent22 added upstream There's a problem with upstream code. and removed high High priority issues labels Jan 21, 2021
@CalebJohn
Copy link
Collaborator

Thanks @flintning this confirms that the issue is with the editor component that Joplin uses (CodeMirror). This means that the behaviour might be eventually fixed on their end. I'll also be thinking about this and if there is a possible fix on the Joplin side.

@fintfire
Copy link
Author

fintfire commented Apr 23, 2021

I've put this issue to discuss.codemirror.net, they said that "This is unlikely to be fixed in the current 5.x versions (which they are probably using), but if they ever upgrade to 6.x, the problem should no longer exist there."
https://discuss.codemirror.net/t/the-postion-of-input-box-is-wrong-when-using-chinese-input-method/3109

@CalebJohn
Copy link
Collaborator

That's good to know. I would like to eventually upgrade Joplin to Codemirror 6.x, but it likely won't happen within the next year.

@wh201906
Copy link
Contributor

I've test your URL. The overlapping problem also existed but much better than Joplin.

I cannot reproduce this result on the website of CodeMirror5. The IME panel doesn't cover the text
#8179 (comment)

  1. Plus, the demo on the CodeMirror5 website also works fine. The panel overlaps the line I'm editing vertically, but it's always behind the cursor.

图片图片图片

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms upstream There's a problem with upstream code.
Projects
None yet
Development

No branches or pull requests

4 participants