Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Provide my own master keys? #389

Closed
ghost opened this issue Apr 8, 2018 · 2 comments
Closed

Feature request: Provide my own master keys? #389

ghost opened this issue Apr 8, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 8, 2018

Operating system

  • Windows
  • macOS
  • Linux
  • Android
  • iOS

Application

  • Desktop
  • Mobile
  • Terminal

Kudos

First of all, awesome product! I tried working with the Simplenote team about a year ago to add E2EE to their protocol and apps (even provided a POC patch and had it working on Android), but they said they were not interested and didn't think it would integrate well with Simplenote's other goals. (I can't believe that security isn't designed into these products from day 1.) So, kudos to you for designing Joplin with security in mind!

Issue

However, the biggest security hole I see is the transmitting and storage of the encrypted master keys. (I admit I have not read the code to see how they are encrypted using the password -- which would be nice to point out in the docs -- but ...) Handling this in other ways seems to be more secure, no?

Recommended Solutions

Can we have a feature where we can paste in our own base64-encoded master keys (like from PGP)?

Or, better yet, how about integration with a tool that is already designed to handle this for us ... like Open Keychain (Android) / GnuPG, etc.?

Thanks!

@laurent22
Copy link
Owner

No plan for this at the moment, but a button to export/import a master key, and a checkbox to disable syncing of master keys could be an option. Doc is on the website.

@ghost
Copy link
Author

ghost commented Apr 11, 2018

I found the doc that describes sort-of how the encryption works, but it does not say how it encrypts the master keys with the password (algorithm, etc.), right?

This would be valuable to know without having to dig into the code, I think.

Thanks!

@lock lock bot locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant