Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search with colons will confuse search #3871

Closed
alexanderadam opened this issue Oct 5, 2020 · 13 comments
Closed

Search with colons will confuse search #3871

alexanderadam opened this issue Oct 5, 2020 · 13 comments
Labels

Comments

@alexanderadam
Copy link

alexanderadam commented Oct 5, 2020

Environment

Joplin version: 1.1.4
Platform: Linux
OS specifics: doesn't matter

Steps to reproduce

  1. search for https://github.com, ActiveSupport::Duration or any other thing with colons

Describe what you expected to happen

Finding only my notes with the terms https://github.com or ActiveSupport::Duration. But the search will simply show some notes that don't contain the term.

@alexanderadam alexanderadam added the bug It's a bug label Oct 5, 2020
@laurent22 laurent22 removed the bug It's a bug label Oct 5, 2020
@stale
Copy link

stale bot commented Nov 5, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added stale An issue that hasn't been active for a while... and removed stale An issue that hasn't been active for a while... labels Nov 5, 2020
@stale
Copy link

stale bot commented Dec 19, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added stale An issue that hasn't been active for a while... and removed stale An issue that hasn't been active for a while... labels Dec 19, 2020
@renesugar
Copy link

Joplin for Desktop
Joplin 1.2.6 (prod, darwin)
Revision: f5f117c (master)

Searches with URLs used to work. But, now, I am seeing the same problem.

Any search containing a colon makes the Joplin UI unresponsive.

@JackGruber
Copy link
Contributor

I think you should update and try your search again. Because the last stable version is 1.5.14with many search fixes.
I can search without a problem for URLs or something like this "::-webkit"

@alexanderadam
Copy link
Author

alexanderadam commented Jan 9, 2021

I can search without a problem for URLs or something like this "::-webkit"

I just tried it again (I'm also on v1.5.14) and if I search something like https://foobar.com it still shows many notes that doesn't have the string https://foobar.com in it.

Could it be related to some setting or so? 🤔

@renesugar
Copy link

Joplin 1.5.14 (prod, darwin)
Revision: 9e076bf (master)

I am still seeing a problem with the latest version.

  • searching for rt.live (with no double quotes) works
  • searching for https://rt.live/ (with no double quotes) freezes the UI.
  • searching for "https://rt.live/" (with double quotes) works

@JackGruber
Copy link
Contributor

@alexanderadam please se doc https://joplinapp.org/#searching

One drawback of Full Text Search is that it ignores most non-alphabetical characters

You have to use /"https://foobar.com"

@renesugar
Please also note the search syntax because of the non-alphabetical characters.
On windows I can't reproduce the freeze, no matter how I perform the search

@alexanderadam
Copy link
Author

alexanderadam commented Jan 9, 2021

@alexanderadam please se doc https://joplinapp.org/#searching

One drawback of Full Text Search is that it ignores most non-alphabetical characters

Well, it would be perfectly fine if this would actually be the case. 😉
And this is also what I would expect.
Because in this case https://foobar.com and https foobar com would have the same outcome, right?
But they clearly don't have the same output. The first one seem to match to all(?) notes whereas the latter is working like it should.

I have rather the feeling that https:… is wrongfully interpreted as a search filter although it is none, according to the documentation that you mentioned.
I don't know whether my assumption is right, though. But if it is, non-search filters obviously shouldn't be threaten as filters.
Otherwise this probably leads to unexpected behaviour.

But again, I don't know whether this is really the case. Somebody with insights of the code base can clarify this probably.

@stale
Copy link

stale bot commented Feb 13, 2021

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added stale An issue that hasn't been active for a while... and removed stale An issue that hasn't been active for a while... labels Feb 13, 2021
@stale
Copy link

stale bot commented Mar 19, 2021

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added stale An issue that hasn't been active for a while... and removed stale An issue that hasn't been active for a while... labels Mar 19, 2021
@stale
Copy link

stale bot commented Jun 3, 2021

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@roman-r-m
Copy link
Collaborator

Maybe @naviji would know if this is a bug or maybe a limitation of Joplin's FTS implementation

@JackGruber
Copy link
Contributor

It's a bug. The last time when I took a look at it the word bevor : was interpreted as a filter key word.
I just haven't had time to fix the bug yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants