Unable to cancel syncing on desktop

[acarasimon96]

The Synchronize button wouldn't respond when you try to cancel the syncing process by clicking the button, and the app would continue to sync as normal.

I'm unsure when this behavior (I see this as a regression) started to appear, since I recently upgraded Joplin from around 1.0.227 to 1.0.245. This might be related to #3734, but this occurs regardless if there are changes to sync or not.

Environment

Joplin version: 1.0.245
Platform: Linux
OS specifics: Manjaro distro, Kernel 5.8

Steps to reproduce

1. Click on the Synchronize button if the app isn't syncing
2. While the button says "Cancel" and the icon on the left side of the text spins, click on the button again

Describe what you expected to happen

The word "Canceling..." would appear above the button immediately when pressed, and when the process completes, it's replaced by "Completed" followed by the current timestamp.

Instead, I got lines such as "Created remote items" and "Fetching items" that are typical of a successful sync.

Logfile

The following line gets added to the DevTools console every time I try to click on the Synchronize button while the app is syncing:

/usr/share/joplin/resources/app.asar/lib/services/CommandService.js:144 CommandService::execute: synchronize null

log.txt output

2020-09-16 19:05:41: "KeychainService: check was already done - skipping. Supported:", "0"
2020-09-16 19:05:41: "Client ID: 5a8cf16ff93a4e6fbbdc99f0cc3f054b"
2020-09-16 19:05:41: "Trying to load 0 master keys..."
2020-09-16 19:05:41: "Loaded master keys: 0"
2020-09-16 19:05:41: "ResourceFetcher: Auto-add resources: Mode: manual"
2020-09-16 19:05:41: "ResourceFetcher: Auto-added resources: 0"
2020-09-16 19:05:41: "Trying to load 0 master keys..."
2020-09-16 19:05:41: "Loaded master keys: 0"
2020-09-16 19:05:41: "Scheduling sync operation...", "10000"
2020-09-16 19:05:41: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:41: "Trying to load 0 master keys..."
2020-09-16 19:05:41: "Loaded master keys: 0"
2020-09-16 19:05:41: "Scheduling sync operation...", "10000"
2020-09-16 19:05:41: "Trying to load 0 master keys..."
2020-09-16 19:05:41: "Loaded master keys: 0"
2020-09-16 19:05:41: "Scheduling sync operation...", "10000"
2020-09-16 19:05:41: "app.start: doing regular boot"
2020-09-16 19:05:41: "Refreshing notes:", "null", "null"
2020-09-16 19:05:41: "Trying to load 0 master keys..."
2020-09-16 19:05:41: "Loaded master keys: 0"
2020-09-16 19:05:41: "Scheduling sync operation...", "10000"
2020-09-16 19:05:41: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:41: "Trying to load 0 master keys..."
2020-09-16 19:05:41: "Loaded master keys: 0"
2020-09-16 19:05:41: "Scheduling sync operation...", "10000"
2020-09-16 19:05:41: "Trying to load 0 master keys..."
2020-09-16 19:05:41: "Loaded master keys: 0"
2020-09-16 19:05:41: "Scheduling sync operation...", "10000"
2020-09-16 19:05:41: "Refreshing notes:", "2", "eecefc5eb69a4155a04f3bf92f099ef0"
2020-09-16 19:05:41: "Scheduling sync operation...", "10000"
2020-09-16 19:05:41: "RevisionService::runInBackground: Starting background service with revision collection interval 600000"
2020-09-16 19:05:42: "Loading existing note", "3e4e1f26dbc14ce1a767016aa8b56e15"
2020-09-16 19:05:42: "Loaded note:", "[redacted]"
2020-09-16 19:05:42: "DecryptionWorker: cannot start because no master key is currently loaded."
2020-09-16 19:05:45: "RevisionService::maintenance: Starting..."
2020-09-16 19:05:45: "RevisionService::maintenance: Service is enabled"
2020-09-16 19:05:46: "RevisionService::collectRevisions: Created revisions for 0 notes"
2020-09-16 19:05:46: "RevisionService::maintenance: Done in 103ms"
2020-09-16 19:05:47: "Saving updated OneDrive auth."
2020-09-16 19:05:47: "Token expired: refreshing..."
2020-09-16 19:05:48: "Saving updated OneDrive auth."
2020-09-16 19:05:49: "Scheduling sync operation...", "0"
2020-09-16 19:05:49: "Preparing scheduled sync"
2020-09-16 19:05:49: "Starting scheduled sync"
2020-09-16 19:05:49: "Sync: starting: Starting synchronisation to target 3... [1600304749106]"
2020-09-16 19:05:49: "get /drive/root:/Apps/Joplin/info.json"
2020-09-16 19:05:49: "Scheduling sync operation...", "0"
2020-09-16 19:05:49: "Preparing scheduled sync"
2020-09-16 19:05:49: "Starting scheduled sync"
2020-09-16 19:05:49: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:49: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:49: "Scheduling sync operation...", "0"
2020-09-16 19:05:49: "Preparing scheduled sync"
2020-09-16 19:05:49: "Starting scheduled sync"
2020-09-16 19:05:49: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:49: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:50: "Sync target info:", "{"version":2}"
2020-09-16 19:05:50: "list /drive/root:/Apps/Joplin"
2020-09-16 19:05:50: "list /drive/root:/Apps/Joplin"
2020-09-16 19:05:50: "Scheduling sync operation...", "0"
2020-09-16 19:05:50: "Preparing scheduled sync"
2020-09-16 19:05:50: "Starting scheduled sync"
2020-09-16 19:05:50: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:50: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:50: "put /drive/root:/Apps/Joplin/temp/timeCheck563478.txt", "null"
2020-09-16 19:05:50: "Scheduling sync operation...", "0"
2020-09-16 19:05:50: "Preparing scheduled sync"
2020-09-16 19:05:50: "Starting scheduled sync"
2020-09-16 19:05:50: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:50: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:51: "Scheduling sync operation...", "0"
2020-09-16 19:05:51: "Preparing scheduled sync"
2020-09-16 19:05:51: "Starting scheduled sync"
2020-09-16 19:05:51: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:51: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:51: "stat /drive/root:/Apps/Joplin/temp/timeCheck563478.txt"
2020-09-16 19:05:51: "Scheduling sync operation...", "0"
2020-09-16 19:05:51: "Preparing scheduled sync"
2020-09-16 19:05:51: "Starting scheduled sync"
2020-09-16 19:05:51: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:51: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:51: "SearchEngine: Updating FTS table..."
2020-09-16 19:05:51: "delete /drive/root:/Apps/Joplin/temp/timeCheck563478.txt"
2020-09-16 19:05:51: "put /drive/root:/Apps/Joplin/locks/sync_desktop_5a8cf16ff93a4e6fbbdc99f0cc3f054b.json", "null"
2020-09-16 19:05:51: "SearchEngine: Updated FTS table in 1ms. Inserted: 0. Deleted: 0"
2020-09-16 19:05:52: "list /drive/root:/Apps/Joplin"
2020-09-16 19:05:52: "list /drive/root:/Apps/Joplin"
2020-09-16 19:05:52: "Scheduling sync operation...", "0"
2020-09-16 19:05:52: "Preparing scheduled sync"
2020-09-16 19:05:52: "Starting scheduled sync"
2020-09-16 19:05:52: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:52: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:52: "Scheduling sync operation...", "0"
2020-09-16 19:05:52: "Preparing scheduled sync"
2020-09-16 19:05:52: "Starting scheduled sync"
2020-09-16 19:05:52: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:52: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:53: "Scheduling sync operation...", "0"
2020-09-16 19:05:53: "Preparing scheduled sync"
2020-09-16 19:05:53: "Starting scheduled sync"
2020-09-16 19:05:53: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:53: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:54: "stat /drive/root:/Apps/Joplin/89ee6382db314b73aeb19fd90b26ed38.md"
2020-09-16 19:05:54: "Sync: createRemote: remote does not exist, and local is new and has never been synced: Revision: (Local 89ee6382db314b73aeb19fd90b26ed38)"
2020-09-16 19:05:54: "put /drive/root:/Apps/Joplin/89ee6382db314b73aeb19fd90b26ed38.md", "null"
2020-09-16 19:05:54: "Scheduling sync operation...", "0"
2020-09-16 19:05:54: "Preparing scheduled sync"
2020-09-16 19:05:54: "Starting scheduled sync"
2020-09-16 19:05:54: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:54: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:55: "Scheduling sync operation...", "0"
2020-09-16 19:05:55: "Preparing scheduled sync"
2020-09-16 19:05:55: "Starting scheduled sync"
2020-09-16 19:05:55: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:55: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:55: "Scheduling sync operation...", "0"
2020-09-16 19:05:55: "Preparing scheduled sync"
2020-09-16 19:05:55: "Starting scheduled sync"
2020-09-16 19:05:55: "Synchronisation is already in progress. State: in_progress"
2020-09-16 19:05:55: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:56: "delta /drive/root:/Apps/Joplin"
2020-09-16 19:05:57: "Sync: fetchingTotal: Fetching delta items from sync target"
2020-09-16 19:05:57: "get /drive/root:/Apps/Joplin/temp"
2020-09-16 19:05:57: "get /drive/root:/Apps/Joplin/locks"
2020-09-16 19:05:57: "get /drive/root:/Apps/Joplin/89ee6382db314b73aeb19fd90b26ed38.md"
2020-09-16 19:05:57: "Sync: fetchingProcessed: Processing fetched item"
2020-09-16 19:05:57: "Sync: fetchingProcessed: Processing fetched item"
2020-09-16 19:05:57: "Sync: fetchingProcessed: Processing fetched item"
2020-09-16 19:05:58: "delete /drive/root:/Apps/Joplin/locks/sync_desktop_5a8cf16ff93a4e6fbbdc99f0cc3f054b.json"
2020-09-16 19:05:59: "Sync: finished: Synchronisation finished [1600304749106]"
2020-09-16 19:05:59: "Operations completed: "
2020-09-16 19:05:59: "createRemote: 1"
2020-09-16 19:05:59: "fetchingTotal: 3"
2020-09-16 19:05:59: "fetchingProcessed: 3"
2020-09-16 19:05:59: "Total folders: 14"
2020-09-16 19:05:59: "Total notes: 186"
2020-09-16 19:05:59: "Total resources: 19"
2020-09-16 19:05:59: "Setting up recurrent sync with interval 1800"
2020-09-16 19:05:59: "Sync has finished and note has never been changed - reloading it"
2020-09-16 19:06:00: "DecryptionWorker: cannot start because no master key is currently loaded."
2020-09-16 19:06:11: "ResourceService::indexNoteResources: Start"
2020-09-16 19:06:12: "ResourceService::indexNoteResources: Completed"
2020-09-16 19:06:12: "ResourceService::deleteOrphanResources:", "[]"

Note that I clicked on the sync button multiple times every time I reproduced this behavior.

[CalebJohn]

Hi @acarasimon96 thanks for the detailed bug report!

This is a known issue and is already on the roadmap! This bug will be fixed in version 1.2.

I'm going to close this in order to keep things tidy, but we appreciate the report.