-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow rendering of KaTeX on W10 #2357
Comments
Log does not show anything interesting. |
On start-up, Joplin uses about 175-200 MB of RAM. After working for 45-60 minutes on a single note file, it rises to 500 MB. It is at this point that the renderer becomes a bit choppy. |
Katex code blocks are cached, so maybe the cache is malfunctioning and adding data without deleting old one. |
There are quite some instances where I use inline code blocks. Especially in the part I wrote the last hour a significant amount of inline code blocks were written, but not a lot of text. |
I have been having the same issue and resorted to reinstalling the previous version as a workaround. |
I'm not seeing any slow down actually. Can someone post one example Markdown that definitely shows the problem? |
Hi. I am also on 1.0.178 (the app update pops for 1.0.179 but does not download it), but on OS X. |
I can confirm Ibo34's issue. It happens even when I only update the file with mostly text, as opposed to heavy KaTeX usage. |
I also notice some latex commands stopped working... Like \mathbb{} and some others. Used o work very well. |
--updated: manage to reinstall with Homebrew. Now on 1.0.179... but the KaTeX flickering problem and changes to some functions (for instance \mathbb \reals) is also in 1.0.179. This is bad... I tried to downgrade to 1.0.177 and I am not sure what went wrong but I cannot open the app anymore. It says it is opened but the main windows does not appear. I can access the menu but nothing happens. Only "about Joplin" seems to work and opens a window on the bottom left of the screen... I tried to reinstall 1.0.177, 1.0.178... Nothing seems to work. |
As this is a different issue, could you open a new issue with a complete markdown example, and what rendering you expect? |
Sure... it is just these two things seems to have appeared at the same time. I'll open a new issue. |
Did you have any success reproducing the issue? I also found a new workaround: disabling and then reenabling KaTeX seems to work for a while |
@ulucs, this workaround is to fix what issue? |
@laurent22 The lag. |
Yeah, it is about the lag. I also noticed the issue is also present in version 1.0.177 |
@ArjenB96, if you could post an example of note that shows this memory leak it might help. The more sample notes we have the better. |
I hope I did it right, I tried to export two notes in .jex file. |
true @ulucs. it seems to help a bit. |
I couldn't quite replicate any slow down or memory leak on my side (it stays at 90MB on Windows and loads fast), however I've optimised how the Katex assets and other plugin assets (CSS and fonts) are loaded and I think it should make it faster and consume less RAM. Another thing that was changed in a recent release is that rendering is now asynchronous but I hope it's not the issue as that will be much harder to fix. This change will be in the next release. |
When working on my note (linked below) I notice a signifcant increase in render time when I increase the amount of KaTeX, even though I do not find it to be that much. Even after typing single letters and pausing slightly, the editor freezes for ~0.5-1 seconds to render the entire file and this disturbs my work flow.
I do not experience the issue as much on my laptop running macOS Mojave. Hiding the rendered version using the Layout button does not help the issue.
Environment
Joplin version: 1.0.178 (prod, win32)
Platform: Windows
OS specifics: 10, standard editor settings with 'Nord' them enabled.
Steps To Reproduce
slow_render.zip
Describe what you expected to happen:
Much less render time, allowing for a more smooth work flow.
The text was updated successfully, but these errors were encountered: