Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux Appimage does not ask for integration with OS #2332

Closed
dpoulton-github opened this issue Jan 21, 2020 · 6 comments
Closed

Linux Appimage does not ask for integration with OS #2332

dpoulton-github opened this issue Jan 21, 2020 · 6 comments
Labels
bug It's a bug stale An issue that hasn't been active for a while...

Comments

@dpoulton-github
Copy link

As reported in the forum for:
1.0.178 and
1.0.177

Rasied at the request of @laurent22 and on behalf of another without a GitHub account.

Environment

Version: Joplin v1.0.178
Version: Joplin v1.0.177
OS: Linux

Steps to reproduce

  1. Download, chmod+x and run Joplin-1.0.178.Appimage.
  2. No request is made by Joplin to integrate the application with the operating system

Describe what you expected to happen:

Expected behaviour would be that Joplin asks if the user wishes to integrate Joplin with the OS.

@dpoulton-github dpoulton-github added the bug It's a bug label Jan 21, 2020
@thearchivalone
Copy link
Contributor

thearchivalone commented Jan 21, 2020

I'm not sure how to fix the issue, but I did find out what changed between both AppImages. When running v1.0.175 from the command line, it throws an interesting error on Artix Linux:

Dialog-AppImage-Joplin-175

Artix Linux is an off shoot of Arch Linux that has some slightly different packages and a totally different configuration for running programs when booting up. Because I don't use any of the standard desktop environments (I opt for just a keyboard ran, lightweight tiling manager with almost no software installed), I'm missing what most apps look for when they need to throw a dialogue for the user. After installing any of those three apps that the images are looking for, I get the expected outcome described above.

After extracting 1.0.175's, 1.0.177's and 1.0.178's AppImages (using the --appimage-extract argument) and running a diff on both 1.0.175's and 1.0.178's AppRun scripts, it looks like the above error message and information was changed between versions:

diffs.txt

The "<" symbols represent what was removed between versions and the ">" represents what was either added or displaced.

After running a diff between 1.0.177's and 1.0.178's AppRun scripts, there is no change between the two scripts, so I won't be providing a diff for them.

I hope that this information is helpful with squashing this bug. :D

@thearchivalone
Copy link
Contributor

thearchivalone commented Jan 21, 2020

Patching the AppRun script using this patch (basically, diffs.txt from the previous post, but reversed) fixed the issue on my end.

diffs2.txt

Steps to Reproduce

  1. Download, chmod +x Joplin-1.0.178.AppImage, and execute in your terminal of choice:
    ./Joplin-1.0.178.AppImage --appimage-extract
  2. Execute:
    cd squashfs-root
  3. Make sure diffs2.txt is saved in squashfs-root before running this next step
  4. Execute:
    patch -p1 AppRun diffs2.txt
  5. Execute:
    ./AppRun
  6. Profit

@ghost
Copy link

ghost commented Jan 25, 2020

This problem is still present in v1.0.179

@thearchivalone
Copy link
Contributor

It looks like this is an issue that may need to be sent upstream to the AppImage devs. I thought it was something that was specific to this project and something the devs here changed but it doesn't look it.

@stale
Copy link

stale bot commented Apr 15, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Apr 15, 2020
@stale
Copy link

stale bot commented Apr 22, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Apr 22, 2020
@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug stale An issue that hasn't been active for a while...
Projects
None yet
Development

No branches or pull requests

2 participants