-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please fix viewing rtl notes #2047
Comments
So is the only issue when the note is rendered as HTML? The text editor is fine? I'm completely ignorant about ltr language so I'm not sure I can do much about it, but it might be good to narrow down the issue. |
Does it work if you paste your Markdown text in there? https://markdown-it.github.io/ |
No, it doesn't work. I think this is not Joplin's bug. There are two workaround for this i think:
Is there an easy way to do this? What do you think about this problem? |
It's unfortunate markdown-it (the lib we use) doesn't support RTL but it means we can't do much about it. Based on this issue it looks like there's no easy fix either. Making markdown viewing optional is not an option as that would be too complex and doesn't even feel like a good solution (how about images, formatting, etc.). I think we'd need someone familiar with rtl text and willing to spend lots of time to update markdown-it and add support for it. That would be the ideal solution. Perhaps a bounty or something could help achieve that, but that's something to check with the markdown-it repository. |
Oh, Thanks. |
I would expect there's no easy workaround, however if you do find one, please share as in this case we might be able to add it to the app directly. See here for info on how to setup custom CSS: https://joplinapp.org/#custom-css |
Oh, Thanks. Does mobile devices also support css? In the end, Thank you very much for the time and energy spent for this issue and for developing Joplin. |
@3j9fkyahunqoxwqu, could you post an example of Markdown with Arabic text, as well as an image on how it should render? I have no idea about anything here because I can't read Arabic. If I have an example then I can try to add these CSS properties you mentioned to see if they make a difference. |
Hello |
Hello I tested the code that @CalebJohn wrote and it was exactly what i read about it in that github issue but because i didn't know css, i didn't know how it should be written. This css make RTL notes far better. This is the texts i wrote: And this is the texts that rendered on viewing mode: As you see in the screenshot the only problem with this workaround is lines that starts with LTR word but i think it is far better than before. Although i think heavy user can face this problem more (for example when quoting or web clipping may be) but untill someone can fix it and send pull request, or at least has more knowledge than me to help, i think this workaround at least make joplin usable for most of personal notes and ideas. Thank you @laurent22 @CalebJohn |
Environment
Joplin version: 1.0.308
Platform: Android (haven't tested other platforms yet)
OS specifcs: Android 9 (pie)
Steps To Reproduce
Exactly as described in #631
I would like to explain more about it but that issue was locked by bot so i forced to create another one. Excuse me for that.
that the simplenote app that is open-source and also supports markdown don't have this problem, may you please look at it if you had time so may be it can help you to fix this issue ?
Also i think it uses same programing language as joplin.
I mean this app: https://github.com/Automattic/simplenote-android
May be they fixed it by disabling showing notes as markdown by default and enable it only when user explicitly turn markdown button on.
but this is my assumption and i didn't tested markdown rtl writing in it to test if it also has problem for showing rtl like joplin or not (as i don't know about markdown syntax)
But i will test it (i will turn on that button and write a text using markdown and will update this issue in one hour)
Joplin is so great and the only problem is this issue that unfortunately made it unusable for most of my notes.
Also i don't know why but the main page of the app (joplin) that shows note titles show them completely correct and also the title direction is correct in note page.
I attached some screenshots about these.
Thanks
Describe what you expected to happen:
App show content of RTL notes correctly.
Logfile
Screenshots:
This is when when we are writing:
This is when writing completed and the app shows note:
This is the main page of the app:
The text was updated successfully, but these errors were encountered: