Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Attach Any File" cannot attach files with spaces in their names #1684

Closed
charlesdaniels opened this issue Jun 24, 2019 · 3 comments
Closed
Labels
bug It's a bug mobile All mobile platforms

Comments

@charlesdaniels
Copy link

Operating system

  • iOS

Application

  • Mobile

On an up to date (as of time of posting) copy of Joplin for iOS, the "attach any file" button will report The file "..." couldn't be opened because there is no such file on any file that contains spaces in the name. I was trying to attach from the "On my iPhone" "folder" if that matters. It looks like Joplin is URL-encoding the filename, so the spaces get converted to %20, but presumably the iOS file access API does not understand this format.

I would assume as someone not familiar with the Joplin codebase that this is where the response gets checked, and presumably where the necessary conversion code should live. I'm not sure where the native and where the React part of the file picking progress starts though (being familiar with neither React nor iOS personally), so I can't be certain.

Image-1

@laurent22 laurent22 added bug It's a bug essential mobile All mobile platforms labels Jun 24, 2019
@metbril
Copy link
Contributor

metbril commented Jul 3, 2019

duplicate of #659?

@charlesdaniels
Copy link
Author

No, I don't think it's a dupe of #659. I was able to attach a PDF file without spaces in the name, with #659 could not. Also, #659 showed the failure occurring even when there were not spaces in the file name, which is not a behavior I could re-produce.

@TheOnlyGeal
Copy link

Hi,
I still have the issue on iOS (iPhone). Nothing to add to the previous description.

@lock lock bot locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug mobile All mobile platforms
Projects
None yet
Development

No branches or pull requests

4 participants