Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set critical property on environment resource #296

Conversation

sloloris
Copy link
Member

This PR fixes a bug brought to our attention by a customer via the Support team where the critical property was only updating as expected on environments nested on the project resource, but was not functioning as expected on the environment resources themselves.

@sloloris sloloris requested a review from a team as a code owner February 15, 2025 00:11
@sloloris sloloris requested a review from ldhenry February 15, 2025 00:13
Copy link
Collaborator

@ldhenry ldhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Thanks for fixing this.

…onflicting-with-existing-environment-critical-setting-not-respected
@ldhenry ldhenry enabled auto-merge (squash) February 17, 2025 13:36
@ldhenry ldhenry merged commit 3e3cd70 into main Feb 17, 2025
25 checks passed
@ldhenry ldhenry deleted the imiller/REL-5885/terraform-new-environment-conflicting-with-existing-environment-critical-setting-not-respected branch February 17, 2025 13:37
This was referenced Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants