Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launchdarkly_feature_flag_environment errors when fallthrough bucket_by is null #120

Closed
rayward opened this issue Sep 20, 2022 · 3 comments

Comments

@rayward
Copy link

rayward commented Sep 20, 2022

When the bucket_by arg of the fallthrough block of launchdarkly_feature_flag_environment is explicitly set to null, then this error is seen:

Error: failed to update flag "MyFeature" in project "default": 400 Bad Request: {"code":"invalid_request","message":"Percentage rollout must be bucketed by a non-empty attribute name"}

As this arg is optional, it should be valid to specify null, the provider should then omit this param when patching the resource to configure the rollout to use the default bucketing method (by user key).

@ldhenry
Copy link
Collaborator

ldhenry commented Sep 21, 2022

Hey @rayward,

Thanks for bringing this to our attention. The team has started working on a fix and we should have something out soon.

Cheers,
Henry

@lucywyman
Copy link
Contributor

This should be fixed in 2.9.3 of the provider! Let us know if you're still having this issue.

@rayward
Copy link
Author

rayward commented Oct 5, 2022

@lucywyman everything is working great now with the release, thanks!

Tested these scenarios and all behaved as expected:

  • omitting bucket_by arg
  • setting bucket_by to null
  • setting bucket_by to an attribute name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants