Make Error implement std::fmt::Display, std::error::Error and Sync
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure seems to be unrelated. |
cwaldren-ld
reviewed
Mar 2, 2023
|
Hi @hkratz sorry for the delay; needed to fix CI on main branch. Please rebase your branch and hopefully it's good to go. |
This was referenced Nov 15, 2023
Closed
keelerm84
pushed a commit
that referenced
this pull request
Nov 15, 2023
🤖 I have created a release *beep* *boop* --- ## [0.12.0](0.11.0...0.12.0) (2023-11-15) ### ⚠ BREAKING CHANGES * Remove re-export of hyper_rustls types ([#59](#59)) * Bump dependencies ([#58](#58)) ### deps * Bump dependencies ([#58](#58)) ([a7174e3](a7174e3)) ### Features * make Error implement std::fmt::Display, std::error::Error` and Sync ([#47](#47)) ([0eaab6e](0eaab6e)) ### Bug Fixes * Remove re-export of hyper_rustls types ([#59](#59)) ([ec24970](ec24970)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to make it work with error-wrapping libraries like anyhow or eyre. Of course it is also generally a good idea. ;-)
Please check if the error descriptions in the
Displayimplementation are to your liking. Theimpl<E> From<E> for Erroris unused and conflicts withErrorimplementingstd::error::Errorso I removed it.