Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unknown instead of any #95

Closed
josephearl opened this issue Sep 26, 2023 · 1 comment
Closed

Use unknown instead of any #95

josephearl opened this issue Sep 26, 2023 · 1 comment

Comments

@josephearl
Copy link

josephearl commented Sep 26, 2023

Is your feature request related to a problem? Please describe.

Now the SDK has been converted to TypeScript, it should not use any anymore.

Use of any causes problems for library consumers that use TypeScript in strict mode, as well as errors from the recommended set of TypeScript ESLint rules like https://typescript-eslint.io/rules/no-explicit-any/.

any is an escape hatch that disables type checking and allows you to access arbitrary properties, even ones that don’t exist.

Describe the solution you'd like

Use unknown instead of any. This would be a breaking change so would require a major version bump following SemVer.

@josephearl
Copy link
Author

Moved to the new repo launchdarkly/js-core#286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant