Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): blockscout is default verifier #2775

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Apr 30, 2024

No description provided.

Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: efe811b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/cli Patch
mock-game-contracts Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -25,7 +25,7 @@ const verifyOptions = {
desc: "Enable batch processing of RPC requests in viem client (defaults to batch size of 100 and wait of 1s)",
},
srcDir: { type: "string", desc: "Source directory. Defaults to foundry src directory." },
verifier: { type: "string", desc: "The verifier to use. Default to sourcify", default: "sourcify" },
verifier: { type: "string", desc: "The verifier to use. Default to sourcify", default: "blockscout" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
verifier: { type: "string", desc: "The verifier to use. Default to sourcify", default: "blockscout" },
verifier: { type: "string", desc: "The verifier to use. Defaults to blockscout", default: "blockscout" },

@holic holic marked this pull request as ready for review April 30, 2024 22:51
@holic holic requested review from ludns, qbzzt and alvrs as code owners April 30, 2024 22:51
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked into this briefly and doing conditional verifying based on chain is a little more involved (because we have no chain reference, it's inferred via rpc), so doing the simple/easy thing to unblock

@holic holic merged commit 0b6b70f into main Apr 30, 2024
10 of 12 checks passed
@holic holic deleted the yonadaaa/blockscout-default-verifier branch April 30, 2024 22:52
dhvanipa pushed a commit to tenetxyz/mud that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants