Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-contracts follow up #880

Closed
3 of 4 tasks
holic opened this issue May 17, 2023 · 2 comments
Closed
3 of 4 tasks

dev-contracts follow up #880

holic opened this issue May 17, 2023 · 2 comments

Comments

@holic
Copy link
Member

holic commented May 17, 2023 •
edited by alvrs
Loading

  • a typo in mud config breaks the runner/watcher, should prob watch everything that isn't the file watcher in a try/catch so we can retry even after bad config changes
  • adding an enum didn't seem to retrigger the codegen + deploy process?
  • changing PostDeploy didn't seem to redeploy
  • lots of duplicate behavior inside dev-contracts as in template scripts (initialize, etc.), can we consolidate?
@holic holic mentioned this issue May 18, 2023
Merged
@holic
Copy link
Member Author

holic commented Oct 11, 2023

I think this is ~done?

@holic holic closed this as completed Oct 11, 2023
@alvrs
Copy link
Member

alvrs commented Oct 11, 2023

the first point is open again but tracked in #1731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holic @alvrs